Fix CI: Keep Python README within package builds - #1040
Merged
tankyleo merged 1 commit intoAug 12, 2026
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
tankyleo
reviewed
Aug 12, 2026
| packages = ["src/ldk_node"] | ||
|
|
||
| [tool.hatch.build.targets.sdist.force-include] | ||
| "../../README.md" = "README.md" |
Contributor
There was a problem hiding this comment.
For now I just had codex review this commit, it had this to say let me know if you want to fix this:
- [P2] Make the sdist README source self-contained _ /home/ubuntu/ldk-node/bindings/python/pyproject.toml:34-34
When an extracted sdist is repackaged, this mapping still resolves ../../README.md outside the extracted package, where that file is absent. Consequently, running a standard build such as python -m build on the sdist raises FileNotFoundError: Forced include not found, even though the archive
contains its own README.md; the sdist configuration should use that local copy when rebuilding.
Contributor
There was a problem hiding this comment.
Here's what codex came up with to fix this, feel free to grab it if it's useful: tankyleo@d5bd4df
Collaborator
Author
There was a problem hiding this comment.
Hmm, strange it didn't find it first. Now amended the commit.
Load the repository README through Hatchling metadata so builds accept the Python package configuration. Include a regular copy in source distributions so archive extraction remains safe. Co-Authored-By: HAL 9000
tnull
force-pushed
the
2026-08-investigate-python-ci
branch
from
August 12, 2026 08:01
aae54bc to
4144da2
Compare
tankyleo
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load the repository README through Hatchling metadata so builds accept the Python package configuration. Include a regular copy in source distributions so archive extraction remains safe.
(As latest
hatchlingsrelease broke our CI)