-
Notifications
You must be signed in to change notification settings - Fork 24
Add RPC functions for keysend, msg signing, and exporting scorer #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I've assigned @joostjager as a reviewer! |
|
One general question that I had for ldk-server is whether we want some light e2e testing? cli->client->server path. Perhaps an |
Yeah that would be nice, probably better for a separate PR though |
|
Yes, agreed on the separate PR for this. It's pre-existing. |
joostjager
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested ack
| LdkServerError::new(InvalidRequestError, "Invalid node_id provided.".to_string()) | ||
| })?; | ||
|
|
||
| let route_parameters = match request.route_parameters { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible to reuse handle_bolt11_send_request matching code?
Relatedly, I recently opened lightningdevkit/ldk-node#766 and tagged it as a BOSS topic. We could however also consider whether we want to move the CLN/LND/Eclair interop tests to the server repo, rather than doing them at the LDK Node level? Although, it is somewhat nice to do it like the other integration tests in Rust. |
tnull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, opened #114 as a follow-up.
f58fb45 to
19fe3c3
Compare
19fe3c3 to
e69361f
Compare
This basically fills out the remaining ldk-node functions that were not used by the RPC/CLI.