(Actually) remove incorrect *mut cast in net-tokio#4694
Merged
TheBlueMatt merged 1 commit intoJun 15, 2026
Conversation
In ae62fa3 we removed an incorrect `&mut`, but failed to actually resolve the mut aliasing bug - there remained a deref of a `*mut` which is similarly invalid. Here we actually fix the bug and also DRY up code marginally. Reported by Project Loupe.
|
👋 Thanks for assigning @valentinewallace as a reviewer! |
Collaborator
|
The change correctly delegates to No issues found. |
valentinewallace
approved these changes
Jun 15, 2026
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ae62fa3 we removed an incorrect
&mut, but failed to actually resolve the mut aliasing bug - there remained a deref of a*mutwhich is similarly invalid. Here we actually fix the bug and also DRY up code marginally.Reported by Project Loupe.