Expose channel fees in ChannelDetails - #824
Closed
valentinewallace wants to merge 1 commit into
Closed
Conversation
We need this to make route hints for invoices.
valentinewallace
force-pushed
the
listchans-expose-feerates
branch
from
March 4, 2021 00:40
7064d27 to
7c7c08b
Compare
Collaborator
|
Fee charged by us is usually not very useful/interesting, I suppose we could export it, but you almost certainly want the fee charged by our counterparty for inbound information, not the other way around - I believe thats the actual reason for #207. |
Codecov Report
@@ Coverage Diff @@
## main #824 +/- ##
==========================================
- Coverage 90.97% 90.95% -0.02%
==========================================
Files 48 48
Lines 26452 26456 +4
==========================================
- Hits 24064 24063 -1
- Misses 2388 2393 +5
Continue to review full report at Codecov.
|
Contributor
Author
|
Dangit, OK revising approach... |
amackillop
added a commit
to moneydevkit/rust-lightning
that referenced
this pull request
Aug 7, 2026
The v0.2.5 rebase dropped the MDK-799 dual-advertise commits because upstream 0.2.2 renumbered SplicePrototype to bit 63, turning their clear_splicing() ACINQ carve-out into a production-bit strip. That left bit-155-only clients unable to splice: we neither advertised a bit they recognize nor recognized the bit they advertise, so LSPS4 would fall back to opening a second channel on every liquidity top-up. We have to assume such clients exist: client version telemetry (MDK-424, lightning-node#824) has not shipped, and the legacy e2e jobs cannot distinguish a splice from the channel-open fallback by design. Reintroduce the bit under a new SplicePrototypeLegacy feature (155 is unused upstream now) and accept it at the splice_channel gate. The wire protocol is unchanged between v0.2 and v0.2.5 (msgs.rs and interactivetxs.rs are byte-identical across the patch series), so a 0.2.5 LSP can splice with a v0.2-fork client; only the negotiation bit moved. The ACINQ carve-out returns unchanged: eclair rejects an Init carrying both 155 (their pre-standard splice bit) and 63. Sunset: once lightningdevkit#824 ships and shows no bit-155 clients, drop the define_feature block, the set_splicing_legacy_optional() call, the strip, and the gate's legacy arm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need this to make route hints for invoices.