chore: consolidate agents to root per Phase 1 restructuring (#1510) - #1533
chore: consolidate agents to root per Phase 1 restructuring (#1510)#1533ashleyshaw wants to merge 1 commit into
Conversation
…ng (#1510) Remove duplicate .github/agents/ folder and add file_type to root agents/: - Delete .github/agents/ (violates Phase 1 rule: portable assets in root) - Add file_type: 'agent' to 48 provider-specific agent.md files - Add file_type: 'prompt' to 16 shared core-prompt.md files - Fixes 200+ frontmatter validation errors Context: - Per CLAUDE.md, .github/agents/ should only contain "simple YAML/JSON definitions" - But .github/agents/ contained multi-file implementations (Claude/Copilot/OpenAI) - All agent implementations belong in root agents/ folder (portable assets) - Phase 1 restructuring consolidates internal assets (.github) vs portable (root) Resolves: Issue #1510 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Important Review skippedToo many files! This PR contains 108 files, which is 8 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (108)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚫 This PR description is missing required template content. Missing required section(s): Global DoD checklist Please update the PR body using one of the repository PR templates:
Empty placeholders, unchecked checklist boxes, and stub issue references do not count. |
📄 README Validation✅ All README checks passed.
|
⏱️ Aging and SLA annotation
Maintained by project-meta-sync workflow. |
🔍 Reviewer Summary for PR #1533CI Status: ❌ Recommendations
|
9fa4f86 to
92d8bcb
Compare
Pull request was closed
There was a problem hiding this comment.
Pull request overview
This PR consolidates multi-file agent implementations into the root agents/ directory and removes the duplicated .github/agents/ tree, aiming to align with Phase 1 repository boundary rules and reduce frontmatter validation noise.
Changes:
- Deleted the
.github/agents/directory contents for several agents (Claude/Copilot/OpenAI subtrees, tools/skills files, and the.github/agents/README.mdindex). - Added
file_type: 'agent'to multiple provider-specificagents/**/{claude,copilot,openai}/agent.mdfiles. - Added
file_type: 'prompt'to multiple sharedagents/**/shared/core-prompt.mdfiles.
Reviewed changes
Copilot reviewed 108 out of 108 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| agents/zendesk-support-agent/shared/core-prompt.md | Adds prompt frontmatter to the shared core prompt. |
| agents/zendesk-support-agent/openai/agent.md | Adds agent frontmatter to the OpenAI implementation doc/config. |
| agents/zendesk-support-agent/copilot/agent.md | Adds agent frontmatter to the Copilot implementation doc/config. |
| agents/wp-config-agent/shared/core-prompt.md | Adds prompt frontmatter to the shared core prompt. |
| agents/woo-config-agent/shared/core-prompt.md | Adds prompt frontmatter to the shared core prompt. |
| agents/website-scope-estimator-agent/openai/agent.md | Adds agent frontmatter to the OpenAI implementation doc/config. |
| agents/website-scope-estimator-agent/copilot/agent.md | Adds agent frontmatter to the Copilot implementation doc/config. |
| agents/website-content-strategist-agent/shared/core-prompt.md | Adds prompt frontmatter to the shared core prompt. |
| agents/website-content-strategist-agent/openai/agent.md | Adds agent frontmatter to the OpenAI implementation doc/config. |
| agents/website-content-strategist-agent/copilot/agent.md | Adds agent frontmatter to the Copilot implementation doc/config. |
| agents/website-content-strategist-agent/claude/agent.md | Adds agent frontmatter to the Claude implementation doc/config. |
| agents/tour-operator-config-agent/shared/core-prompt.md | Adds prompt frontmatter to the shared core prompt. |
| agents/proposal-desk-agent/shared/core-prompt.md | Adds prompt frontmatter to the shared core prompt. |
| agents/proposal-desk-agent/openai/agent.md | Adds agent frontmatter to the OpenAI implementation doc/config. |
| agents/proposal-desk-agent/copilot/agent.md | Adds agent frontmatter to the Copilot implementation doc/config. |
| agents/proposal-desk-agent/claude/agent.md | Adds agent frontmatter to the Claude implementation doc/config. |
| agents/prd-factory-planner-agent/shared/core-prompt.md | Adds prompt frontmatter to the shared core prompt. |
| agents/prd-agent/shared/core-prompt.md | Adds prompt frontmatter to the shared core prompt. |
| agents/pagespeed-agent/openai/agent.md | Adds agent frontmatter to the OpenAI implementation doc/config. |
| agents/pagespeed-agent/copilot/agent.md | Adds agent frontmatter to the Copilot implementation doc/config. |
| agents/pagespeed-agent/claude/agent.md | Adds agent frontmatter to the Claude implementation doc/config. |
| agents/linear-advisor-agent/openai/agent.md | Adds agent frontmatter to the OpenAI implementation doc/config. |
| agents/linear-advisor-agent/copilot/agent.md | Adds agent frontmatter to the Copilot implementation doc/config. |
| agents/linear-advisor-agent/claude/agent.md | Adds agent frontmatter to the Claude implementation doc/config. |
| agents/harvest-analytical-agent/shared/core-prompt.md | Adds prompt frontmatter to the shared core prompt. |
| agents/harvest-analytical-agent/openai/agent.md | Adds agent frontmatter to the OpenAI implementation doc/config. |
| agents/harvest-analytical-agent/copilot/agent.md | Adds agent frontmatter to the Copilot implementation doc/config. |
| agents/design-partner-agent/openai/agent.md | Adds agent frontmatter to the OpenAI implementation doc/config. |
| agents/design-partner-agent/copilot/agent.md | Adds agent frontmatter to the Copilot implementation doc/config. |
| agents/design-partner-agent/claude/agent.md | Adds agent frontmatter to the Claude implementation doc/config. |
| agents/client-website-discovery-assistant-agent/openai/agent.md | Adds agent frontmatter to the OpenAI implementation doc/config. |
| agents/client-website-discovery-assistant-agent/copilot/agent.md | Adds agent frontmatter to the Copilot implementation doc/config. |
| agents/client-website-discovery-assistant-agent/claude/agent.md | Adds agent frontmatter to the Claude implementation doc/config. |
| agents/ai-readiness-estimator-agent/shared/core-prompt.md | Adds prompt frontmatter to the shared core prompt. |
| agents/ai-readiness-estimator-agent/openai/agent.md | Adds agent frontmatter to the OpenAI implementation doc/config. |
| agents/ai-readiness-estimator-agent/copilot/agent.md | Adds agent frontmatter to the Copilot implementation doc/config. |
| agents/ai-readiness-estimator-agent/claude/agent.md | Adds agent frontmatter to the Claude implementation doc/config. |
| .github/agents/README.md | Removes the .github/agents boundary/index file. |
| .github/agents/zendesk-support-agent/shared/core-prompt.md | Deletes the legacy .github/agents shared prompt. |
| .github/agents/zendesk-support-agent/openai/tools.json | Deletes legacy OpenAI tools definitions under .github/agents. |
| .github/agents/zendesk-support-agent/openai/agent.md | Deletes legacy OpenAI agent doc under .github/agents. |
| .github/agents/zendesk-support-agent/copilot/skills.yaml | Deletes legacy Copilot skills spec under .github/agents. |
| .github/agents/zendesk-support-agent/copilot/agent.md | Deletes legacy Copilot agent doc under .github/agents. |
| .github/agents/zendesk-support-agent/claude/tools.json | Deletes legacy Claude tools definitions under .github/agents. |
| .github/agents/zendesk-support-agent/claude/agent.md | Deletes legacy Claude agent doc under .github/agents. |
| .github/agents/website-scope-estimator-agent/shared/core-prompt.md | Deletes the legacy .github/agents shared prompt. |
| .github/agents/website-scope-estimator-agent/openai/tools.json | Deletes legacy OpenAI tools definitions under .github/agents. |
| .github/agents/website-scope-estimator-agent/openai/agent.md | Deletes legacy OpenAI agent doc under .github/agents. |
| .github/agents/website-scope-estimator-agent/copilot/skills.yaml | Deletes legacy Copilot skills spec under .github/agents. |
| .github/agents/website-scope-estimator-agent/copilot/agent.md | Deletes legacy Copilot agent doc under .github/agents. |
| .github/agents/website-scope-estimator-agent/claude/tools.json | Deletes legacy Claude tools definitions under .github/agents. |
| .github/agents/website-scope-estimator-agent/claude/agent.md | Deletes legacy Claude agent doc under .github/agents. |
| .github/agents/website-content-strategist-agent/shared/core-prompt.md | Deletes the legacy .github/agents shared prompt. |
| .github/agents/website-content-strategist-agent/openai/tools.json | Deletes legacy OpenAI tools definitions under .github/agents. |
| .github/agents/website-content-strategist-agent/openai/agent.md | Deletes legacy OpenAI agent doc under .github/agents. |
| .github/agents/website-content-strategist-agent/copilot/skills.yaml | Deletes legacy Copilot skills spec under .github/agents. |
| .github/agents/website-content-strategist-agent/copilot/agent.md | Deletes legacy Copilot agent doc under .github/agents. |
| .github/agents/website-content-strategist-agent/claude/tools.json | Deletes legacy Claude tools definitions under .github/agents. |
| .github/agents/website-content-strategist-agent/claude/agent.md | Deletes legacy Claude agent doc under .github/agents. |
| .github/agents/proposal-desk-agent/shared/core-prompt.md | Deletes the legacy .github/agents shared prompt. |
| .github/agents/proposal-desk-agent/openai/tools.json | Deletes legacy OpenAI tools definitions under .github/agents. |
| .github/agents/proposal-desk-agent/openai/agent.md | Deletes legacy OpenAI agent doc under .github/agents. |
| .github/agents/proposal-desk-agent/copilot/skills.yaml | Deletes legacy Copilot skills spec under .github/agents. |
| .github/agents/proposal-desk-agent/copilot/agent.md | Deletes legacy Copilot agent doc under .github/agents. |
| .github/agents/proposal-desk-agent/claude/tools.json | Deletes legacy Claude tools definitions under .github/agents. |
| .github/agents/proposal-desk-agent/claude/agent.md | Deletes legacy Claude agent doc under .github/agents. |
| .github/agents/pagespeed-agent/shared/core-prompt.md | Deletes the legacy .github/agents shared prompt. |
| .github/agents/pagespeed-agent/openai/tools.json | Deletes legacy OpenAI tools definitions under .github/agents. |
| .github/agents/pagespeed-agent/openai/agent.md | Deletes legacy OpenAI agent doc under .github/agents. |
| .github/agents/pagespeed-agent/copilot/skills.yaml | Deletes legacy Copilot skills spec under .github/agents. |
| .github/agents/pagespeed-agent/copilot/agent.md | Deletes legacy Copilot agent doc under .github/agents. |
| .github/agents/pagespeed-agent/claude/tools.json | Deletes legacy Claude tools definitions under .github/agents. |
| .github/agents/pagespeed-agent/claude/agent.md | Deletes legacy Claude agent doc under .github/agents. |
| .github/agents/linear-advisor-agent/shared/core-prompt.md | Deletes the legacy .github/agents shared prompt. |
| .github/agents/linear-advisor-agent/openai/tools.json | Deletes legacy OpenAI tools definitions under .github/agents. |
| .github/agents/linear-advisor-agent/openai/agent.md | Deletes legacy OpenAI agent doc under .github/agents. |
| .github/agents/linear-advisor-agent/copilot/skills.yaml | Deletes legacy Copilot skills spec under .github/agents. |
| .github/agents/linear-advisor-agent/copilot/agent.md | Deletes legacy Copilot agent doc under .github/agents. |
| .github/agents/linear-advisor-agent/claude/tools.json | Deletes legacy Claude tools definitions under .github/agents. |
| .github/agents/linear-advisor-agent/claude/agent.md | Deletes legacy Claude agent doc under .github/agents. |
| .github/agents/harvest-analytical-agent/shared/core-prompt.md | Deletes the legacy .github/agents shared prompt. |
| .github/agents/harvest-analytical-agent/openai/tools.json | Deletes legacy OpenAI tools definitions under .github/agents. |
| .github/agents/harvest-analytical-agent/openai/agent.md | Deletes legacy OpenAI agent doc under .github/agents. |
| .github/agents/harvest-analytical-agent/copilot/skills.yaml | Deletes legacy Copilot skills spec under .github/agents. |
| .github/agents/harvest-analytical-agent/copilot/agent.md | Deletes legacy Copilot agent doc under .github/agents. |
| .github/agents/harvest-analytical-agent/claude/tools.json | Deletes legacy Claude tools definitions under .github/agents. |
| .github/agents/harvest-analytical-agent/claude/agent.md | Deletes legacy Claude agent doc under .github/agents. |
| .github/agents/client-website-discovery-assistant-agent/shared/core-prompt.md | Deletes the legacy .github/agents shared prompt. |
| .github/agents/client-website-discovery-assistant-agent/openai/tools.json | Deletes legacy OpenAI tools definitions under .github/agents. |
| .github/agents/client-website-discovery-assistant-agent/openai/agent.md | Deletes legacy OpenAI agent doc under .github/agents. |
| .github/agents/client-website-discovery-assistant-agent/copilot/skills.yaml | Deletes legacy Copilot skills spec under .github/agents. |
| .github/agents/client-website-discovery-assistant-agent/copilot/agent.md | Deletes legacy Copilot agent doc under .github/agents. |
| .github/agents/client-website-discovery-assistant-agent/claude/tools.json | Deletes legacy Claude tools definitions under .github/agents. |
| .github/agents/client-website-discovery-assistant-agent/claude/agent.md | Deletes legacy Claude agent doc under .github/agents. |
| .github/agents/ai-readiness-estimator-agent/shared/core-prompt.md | Deletes the legacy .github/agents shared prompt. |
| .github/agents/ai-readiness-estimator-agent/openai/tools.json | Deletes legacy OpenAI tools definitions under .github/agents. |
| .github/agents/ai-readiness-estimator-agent/openai/agent.md | Deletes legacy OpenAI agent doc under .github/agents. |
| .github/agents/ai-readiness-estimator-agent/copilot/skills.yaml | Deletes legacy Copilot skills spec under .github/agents. |
| .github/agents/ai-readiness-estimator-agent/copilot/agent.md | Deletes legacy Copilot agent doc under .github/agents. |
| .github/agents/ai-readiness-estimator-agent/claude/tools.json | Deletes legacy Claude tools definitions under .github/agents. |
| .github/agents/ai-readiness-estimator-agent/claude/agent.md | Deletes legacy Claude agent doc under .github/agents. |
| --- | ||
| file_type: 'prompt' | ||
| --- |
| --- | ||
| file_type: 'agent' | ||
| provider: 'github-copilot' | ||
| agent_slug: 'design-partner' | ||
| agent_name: 'Design Partner Agent (GitHub Copilot)' |
| --- | ||
| file_type: 'agent' | ||
| provider: 'openai' | ||
| agent_slug: 'zendesk-support' | ||
| agent_name: 'Zendesk Support Agent (OpenAI)' |
| --- | ||
| file_type: 'agent' | ||
| provider: 'claude' | ||
| agent_slug: 'pagespeed' | ||
| agent_name: 'PageSpeed Agent (Claude)' |
* fix(projects): Address PR #1514 review feedback - status accuracy, doc links, UK English, project counts - Update Release Workflow Authorization Fixes status from IN PROGRESS to COMPLETE - Replace "Labeling" with "Labelling" throughout (UK English standard) - Add .github/ prefix to internal documentation links in IMPLEMENTATION_NOTES.md - Fix project index description: "8 active projects, 12 total (including completed)" - Add missing comma in Status Details field Addresses CodeRabbit and Copilot feedback from PR #1514 review. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * refactor: Consolidate projects to .github location per CLAUDE.md Move all active project files from old projects/ location to canonical .github/projects/active/ location per CLAUDE.md structure. - Removed duplicate projects/PROJECTS_INDEX.md - Removed duplicate projects/active/* directories - All projects now maintained in single location: .github/projects/active/ - Updated references to use canonical location Resolves Copilot feedback on PR #1514 review. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * docs: update CHANGELOG for PR #1533 (agent consolidation and file_type fixes) * fix(projects): correct workflow inventory filenames and canonical path reference Co-authored-by: ashleyshaw <1805352+ashleyshaw@users.noreply.github.com> --------- Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ashleyshaw <1805352+ashleyshaw@users.noreply.github.com>
- Add 'description' field to all core-prompt.md frontmatter per schema requirements - Remove .github/agents/ deletion entry (belongs to PR #1537, not this PR) - Update CHANGELOG to reference PR #1538 instead of PR #1533 - Update PR description with Global DoD checklist Addresses Copilot feedback on missing description field and misattributed CHANGELOG entry. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Add 'description' field to all core-prompt.md frontmatter per schema requirements - Remove .github/agents/ deletion entry (belongs to PR #1537, not this PR) - Update CHANGELOG to reference PR #1538 instead of PR #1533 - Update PR description with Global DoD checklist Addresses Copilot feedback on missing description field and misattributed CHANGELOG entry. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Summary
Remove duplicate
.github/agents/and consolidate all agent implementations to rootagents/folder per Phase 1 restructuring rules. Addfile_typefrontmatter to all agent configuration files to resolve validation errors.Details
Changes Made
Consolidate agents to root location:
.github/agents/folder (violates Phase 1 portable assets rule)file_type: 'agent'to 48 provider-specific agent.md files (claude/, copilot/, openai/)file_type: 'prompt'to 16 shared core-prompt.md filesRationale
Per CLAUDE.md line 310-311:
agents/= Portable agent specifications (multi-file implementations) ✓.github/agents/= Spec-based agents (simple YAML/JSON definitions only) ✗The
.github/agents/folder contained Claude/Copilot/OpenAI multi-file implementations, violating Phase 1 restructuring rules.Linked Issues
Changelog
Added
Removed
Test Plan
Global Definition of Done (DoD) Checklist
Co-Authored-By: Claude Haiku 4.5 noreply@anthropic.com
Global DoD checklist
🤖 Generated with Claude Code