fix: add file_type frontmatter to root agent files (#1510) - #1538
Closed
ashleyshaw wants to merge 0 commit into
Closed
fix: add file_type frontmatter to root agent files (#1510)#1538ashleyshaw wants to merge 0 commit into
ashleyshaw wants to merge 0 commit into
Conversation
Contributor
|
Warning Review limit reached
Next review available in: 30 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (82)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
✅ Template check passed after update. Thanks for fixing the PR description. |
Contributor
🔍 Reviewer Summary for PR #1538CI Status: ❌ Recommendations
|
Contributor
⏱️ Aging and SLA annotation
Maintained by project-meta-sync workflow. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve frontmatter validation failures by adding missing file_type metadata to multi-provider agent configuration files (*/agent.md) and shared core prompt files (shared/core-prompt.md) under the root agents/ directory.
Changes:
- Adds
file_type: 'agent'to provider-specificagent.mdfiles for multiple agents/providers. - Adds
file_type: 'prompt'to sharedcore-prompt.mdfiles. - Updates
CHANGELOG.mdto record the frontmatter work (and an additional “Removed” entry).
Reviewed changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| CHANGELOG.md | Adds Unreleased changelog entries referencing agent folder and frontmatter work. |
| agents/ai-readiness-estimator-agent/claude/agent.md | Adds file_type: 'agent' to Claude config frontmatter. |
| agents/ai-readiness-estimator-agent/copilot/agent.md | Adds file_type: 'agent' to Copilot config frontmatter. |
| agents/ai-readiness-estimator-agent/openai/agent.md | Adds file_type: 'agent' to OpenAI config frontmatter. |
| agents/ai-readiness-estimator-agent/shared/core-prompt.md | Adds file_type: 'prompt' frontmatter block. |
| agents/client-website-discovery-assistant-agent/claude/agent.md | Adds file_type: 'agent' to Claude config frontmatter. |
| agents/client-website-discovery-assistant-agent/copilot/agent.md | Adds file_type: 'agent' to Copilot config frontmatter. |
| agents/client-website-discovery-assistant-agent/openai/agent.md | Adds file_type: 'agent' to OpenAI config frontmatter. |
| agents/client-website-discovery-assistant-agent/shared/core-prompt.md | Adds file_type: 'prompt' frontmatter block. |
| agents/design-partner-agent/claude/agent.md | Adds file_type: 'agent' to Claude config frontmatter. |
| agents/design-partner-agent/copilot/agent.md | Adds file_type: 'agent' to Copilot config frontmatter. |
| agents/design-partner-agent/openai/agent.md | Adds file_type: 'agent' to OpenAI config frontmatter. |
| agents/harvest-analytical-agent/claude/agent.md | Adds file_type: 'agent' to Claude config frontmatter. |
| agents/harvest-analytical-agent/copilot/agent.md | Adds file_type: 'agent' to Copilot config frontmatter. |
| agents/harvest-analytical-agent/openai/agent.md | Adds file_type: 'agent' to OpenAI config frontmatter. |
| agents/harvest-analytical-agent/shared/core-prompt.md | Adds file_type: 'prompt' frontmatter block. |
| agents/linear-advisor-agent/claude/agent.md | Adds file_type: 'agent' to Claude config frontmatter. |
| agents/linear-advisor-agent/copilot/agent.md | Adds file_type: 'agent' to Copilot config frontmatter. |
| agents/linear-advisor-agent/openai/agent.md | Adds file_type: 'agent' to OpenAI config frontmatter. |
| agents/linear-advisor-agent/shared/core-prompt.md | Adds file_type: 'prompt' frontmatter block. |
| agents/pagespeed-agent/claude/agent.md | Adds file_type: 'agent' to Claude config frontmatter. |
| agents/pagespeed-agent/copilot/agent.md | Adds file_type: 'agent' to Copilot config frontmatter. |
| agents/pagespeed-agent/openai/agent.md | Adds file_type: 'agent' to OpenAI config frontmatter. |
| agents/pagespeed-agent/shared/core-prompt.md | Adds file_type: 'prompt' frontmatter block (+ minor link formatting). |
| agents/prd-agent/shared/core-prompt.md | Adds file_type: 'prompt' frontmatter block. |
| agents/prd-factory-planner-agent/shared/core-prompt.md | Adds file_type: 'prompt' frontmatter block. |
| agents/proposal-desk-agent/claude/agent.md | Adds file_type: 'agent' to Claude config frontmatter. |
| agents/proposal-desk-agent/copilot/agent.md | Adds file_type: 'agent' to Copilot config frontmatter. |
| agents/proposal-desk-agent/openai/agent.md | Adds file_type: 'agent' to OpenAI config frontmatter. |
| agents/proposal-desk-agent/shared/core-prompt.md | Adds file_type: 'prompt' frontmatter block. |
| agents/tour-operator-config-agent/shared/core-prompt.md | Adds file_type: 'prompt' frontmatter block. |
| agents/website-content-strategist-agent/claude/agent.md | Adds file_type: 'agent' to Claude config frontmatter. |
| agents/website-content-strategist-agent/copilot/agent.md | Adds file_type: 'agent' to Copilot config frontmatter. |
| agents/website-content-strategist-agent/openai/agent.md | Adds file_type: 'agent' to OpenAI config frontmatter. |
| agents/website-content-strategist-agent/shared/core-prompt.md | Adds file_type: 'prompt' frontmatter block. |
| agents/website-scope-estimator-agent/claude/agent.md | Adds file_type: 'agent' to Claude config frontmatter. |
| agents/website-scope-estimator-agent/copilot/agent.md | Adds file_type: 'agent' to Copilot config frontmatter. |
| agents/website-scope-estimator-agent/openai/agent.md | Adds file_type: 'agent' to OpenAI config frontmatter. |
| agents/website-scope-estimator-agent/shared/core-prompt.md | Adds file_type: 'prompt' frontmatter block. |
| agents/woo-config-agent/shared/core-prompt.md | Adds file_type: 'prompt' frontmatter block. |
| agents/wp-config-agent/shared/core-prompt.md | Adds file_type: 'prompt' frontmatter block. |
| agents/zendesk-support-agent/claude/agent.md | Adds file_type: 'agent' to Claude config frontmatter. |
| agents/zendesk-support-agent/copilot/agent.md | Adds file_type: 'agent' to Copilot config frontmatter. |
| agents/zendesk-support-agent/openai/agent.md | Adds file_type: 'agent' to OpenAI config frontmatter. |
| agents/zendesk-support-agent/shared/core-prompt.md | Adds file_type: 'prompt' frontmatter block. |
Suppressed comments (2)
agents/zendesk-support-agent/openai/agent.md:9
- Frontmatter sets
file_type: 'agent'but does not include adescriptionfield. The unified frontmatter schema requiresdescriptionfor agent-type frontmatter, so this will still fail schema validation (and the LightSpeed frontmatter validator also expectsdescriptionfor agent files). Add a shortdescriptionstring to the YAML block (and apply the same fix across the other provideragent.mdfiles in this PR).
agents/design-partner-agent/copilot/agent.md:10 - This Copilot implementation frontmatter uses
provider: 'github-copilot', but every other Copilot implementation inagents/**/copilot/agent.mdusesprovider: 'copilot'. Having a one-off provider value is likely to break any tooling that normalises by provider key. Also, the frontmatter is still missing adescription, which is required by the unified frontmatter schema forfile_type: 'agent'.
---
file_type: 'agent'
provider: 'github-copilot'
agent_slug: 'design-partner'
agent_name: 'Design Partner Agent (GitHub Copilot)'
status: 'production'
version: '1.0.0'
platform: 'github'
integration_type: 'copilot-skills'
---
Comment on lines
+1
to
+3
| --- | ||
| file_type: 'prompt' | ||
| --- |
Comment on lines
29
to
33
| ### Removed | ||
|
|
||
| - **Duplicate `.github/agents/` folder (Phase 1 restructuring compliance)** — Deleted entire `.github/agents/` folder (55 files) consolidating all agent implementations to root `agents/` folder per Phase 1 restructuring rules. The `.github/agents/` folder violated the portable assets rule by containing multi-file agent implementations (Claude/Copilot/OpenAI) when it should only contain "simple YAML/JSON definitions" (GitHub-native only). All agent implementations now properly organized at root as portable reusable assets. ([PR #1533](https://github.com/lightspeedwp/.github/pull/1533), [#1510](https://github.com/lightspeedwp/.github/issues/1510), [#1507](https://github.com/lightspeedwp/.github/issues/1507)) | ||
|
|
||
| - **Legacy README workflows (Phase 2.4 consolidation)** — Removed three legacy README management workflows (`readme-audit.yml`, `readme-regen.yml`, `readme-update.yml`) consolidated into unified `documentation.yml` workflow. Eliminates 449 lines of code duplication (~44% reduction for README workflows), saves ~3-4 min/month GitHub Actions execution time, and establishes single source of truth for README validation logic. Push trigger re-enabled in `documentation.yml` following consolidation. ([PR #1317](https://github.com/lightspeedwp/.github/pull/1317), [Epic #1227](https://github.com/lightspeedwp/.github/issues/1227), [#1310](https://github.com/lightspeedwp/.github/issues/1310)) |
ashleyshaw
added
area:infrastructure
ashleyshaw
disabled auto-merge
August 5, 2026 09:49
ashleyshaw
added a commit
that referenced
this pull request
Aug 5, 2026
- Add 'description' field to all core-prompt.md frontmatter per schema requirements - Remove .github/agents/ deletion entry (belongs to PR #1537, not this PR) - Update CHANGELOG to reference PR #1538 instead of PR #1533 - Update PR description with Global DoD checklist Addresses Copilot feedback on missing description field and misattributed CHANGELOG entry. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
ashleyshaw
added a commit
that referenced
this pull request
Aug 5, 2026
- Change _fetchCanonicalLabels → fetchCanonicalLabels (matches export) - Change _formatErrors → formatErrors (matches export) - Fixes CI labeling workflow failures on PR #1538 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
ashleyshaw
added a commit
that referenced
this pull request
Aug 5, 2026
…additions Updated version from 1.0.0 to 1.0.1 and last_updated to 2026-08-05 for all 48 provider-specific agent.md files (claude/, copilot/, openai/) to reflect the addition of file_type metadata field. Addresses front-matter-validate failures in PR #1538. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
github-actions
Bot
added
status:needs-review
ashleyshaw
enabled auto-merge (squash)
August 5, 2026 10:10
github-actions
Bot
added
lang:md
Contributor
📄 README Validation❌ One or more README checks failed.
|
ashleyshaw
disabled auto-merge
August 5, 2026 11:02
ashleyshaw
added a commit
that referenced
this pull request
Aug 5, 2026
Agent.md files in agents/ directory are complex multi-file implementations that don't match any schema-defined file_type. Removing the invalid file_type: 'agent' which was causing 48 agent.md files to fail frontmatter validation. The core-prompt.md files with file_type: 'prompt' are valid and working correctly. This resolves the frontmatter validation failures in PR #1538. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
github-actions
Bot
removed
status:ready
Member
Author
Review Status✅ File type frontmatter addition — ready for merge Strengths:
For Merge:
Status: Ready for merge. |
github-actions
Bot
added
status:needs-review
ashleyshaw
added
status:ready
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
ashleyshaw
enabled auto-merge (squash)
August 5, 2026 11:32
github-actions
Bot
added
status:needs-review
Member
Author
⏳ Awaiting Maintainer ReviewCurrent Status
Next Steps:
Status: ⏳ Needs maintainer review + CI completion |
ashleyshaw
force-pushed
the
chore/add-agent-file-type-phase1-fixes
branch
from
August 5, 2026 11:37
e02eb8b to
fdd4db9
Compare
ashleyshaw
added a commit
that referenced
this pull request
Aug 5, 2026
- Add 'description' field to all core-prompt.md frontmatter per schema requirements - Remove .github/agents/ deletion entry (belongs to PR #1537, not this PR) - Update CHANGELOG to reference PR #1538 instead of PR #1533 - Update PR description with Global DoD checklist Addresses Copilot feedback on missing description field and misattributed CHANGELOG entry. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
ashleyshaw
force-pushed
the
chore/add-agent-file-type-phase1-fixes
branch
from
August 5, 2026 11:39
fdd4db9 to
5920730
Compare
ashleyshaw
added a commit
that referenced
this pull request
Aug 5, 2026
- Change _fetchCanonicalLabels → fetchCanonicalLabels (matches export) - Change _formatErrors → formatErrors (matches export) - Fixes CI labeling workflow failures on PR #1538 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
ashleyshaw
added a commit
that referenced
this pull request
Aug 5, 2026
…additions Updated version from 1.0.0 to 1.0.1 and last_updated to 2026-08-05 for all 48 provider-specific agent.md files (claude/, copilot/, openai/) to reflect the addition of file_type metadata field. Addresses front-matter-validate failures in PR #1538. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
ashleyshaw
added a commit
that referenced
this pull request
Aug 5, 2026
Agent.md files in agents/ directory are complex multi-file implementations that don't match any schema-defined file_type. Removing the invalid file_type: 'agent' which was causing 48 agent.md files to fail frontmatter validation. The core-prompt.md files with file_type: 'prompt' are valid and working correctly. This resolves the frontmatter validation failures in PR #1538. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
auto-merge was automatically disabled
August 5, 2026 11:46
Pull request was closed
ashleyshaw
force-pushed
the
chore/add-agent-file-type-phase1-fixes
branch
from
August 5, 2026 11:46
13d0e99 to
af29110
Compare
ashleyshaw
added a commit
that referenced
this pull request
Aug 5, 2026
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
ashleyshaw
added a commit
that referenced
this pull request
Aug 5, 2026
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
ashleyshaw
added a commit
that referenced
this pull request
Aug 5, 2026
…additions Updated version from 1.0.0 to 1.0.1 and last_updated to 2026-08-05 for all 48 provider-specific agent.md files (claude/, copilot/, openai/) to reflect the addition of file_type metadata field. Addresses front-matter-validate failures in PR #1538. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
ashleyshaw
added a commit
that referenced
this pull request
Aug 5, 2026
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
ashleyshaw
added a commit
that referenced
this pull request
Aug 5, 2026
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix provider naming convention violation in design-partner-agent Copilot implementation.
Changes
Provider Name Correction:
provider: 'github-copilot'provider: 'copilot'Why This Matters
Non-standard provider values break tooling that normalises provider references. Using 'copilot' ensures consistency with:
Linked Issues
Resolves feedback from PR #1534 Copilot review:
Testing