[h2v] Add repush ttl config and filter to the H2V.#10
Merged
adamxchen merged 6 commits intolinkedin:masterfrom Sep 30, 2022
Merged
[h2v] Add repush ttl config and filter to the H2V.#10adamxchen merged 6 commits intolinkedin:masterfrom
adamxchen merged 6 commits intolinkedin:masterfrom
Conversation
majisourav99
requested changes
Sep 28, 2022
This commit introduces two new config REPUSH_TTL_IN_HOURS_OVERRIDE and REPUSH_TTL_POLICY. They are used in conjunction to apply corresponding TTL logic to records. Note that as for now, we only support one REPUSH_TTL_POLICY so its value is hardcoded. The TTL filter uses the chain of responsibility pattern so we can introduce more filters to the Mapper stage. TTL filter also comes with 3 policies w.r.t batch writes. The core implementation will be added in a separate commit.
sushantmane
reviewed
Sep 29, 2022
adamxchen
force-pushed
the
ttlfilter
branch
2 times, most recently
from
eea3e91 to
ef4590e
Compare
Contributor
|
Thanks, @adamxchen |
majisourav99
requested changes
Sep 30, 2022
majisourav99
approved these changes
Sep 30, 2022
2 tasks
eolivelli
pushed a commit
to eolivelli/venice
that referenced
this pull request
May 26, 2023
ZacAttack
pushed a commit
that referenced
this pull request
Jun 1, 2023
…ion with Kafka (#452) * [push-job] Fix VenicePushJob - loading Kafka configuration * [tests] Fix tests failing due to SASL implementation * [controller][server] Ensure that Kafka SASL properties are preserved (#10) * [samza][pulsar-sink] Pass SASL properties to the Producer * [server][pulsar-sink] More fixes about SASL authentication (#11) - Fix Venice Server loading Kafka SASL parameters - Remove JAAS configuration from PulsarSink tests, Kafka is not configured with SASL - Add a generic `writerConfig` to tune the PulsarSink * [tests] Add Kafka SASL integration tests end-to-end (#20) * Fix build * Fix build * Increase code coverage * fix test
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit introduces two new config REPUSH_TTL_IN_HOURS and REPUSH_TTL_POLICY. They are used in conjunction to apply corresponding TTL logic to records. Note that as for now, we only support one REPUSH_TTL_POLICY so its value is hardcoded.
The TTL filter uses the chain of responsibility pattern so we can introduce more filters to the Mapper stage. TTL filter also comes with 3 policies w.r.t batch writes. The core implementation will be added in a separate commit.
How was this PR tested?
unit tests and integration tests
Does this PR introduce any user-facing changes?
Users now can specify the ttl time in hours in the repush job. When the config is specified, the filter will be present during H2V mapper stage. Currently, this filter doesn't do anything but allowing everything flow thru. Its implementation will be introduce in a different PR.