Skip to content

[controller][server][clients] End-To-End support for SASL authentication with Kafka#452

Merged
ZacAttack merged 10 commits intolinkedin:mainfrom
eolivelli:impl/kafka-sasl-end-to-end
Jun 1, 2023
Merged

[controller][server][clients] End-To-End support for SASL authentication with Kafka#452
ZacAttack merged 10 commits intolinkedin:mainfrom
eolivelli:impl/kafka-sasl-end-to-end

Conversation

@eolivelli
Copy link
Copy Markdown
Contributor

@eolivelli eolivelli commented May 26, 2023 •
edited
Loading

Summary

Ensure that SASL configuration is correctly propagated to all the components

Details:

  • copy sasl properties to producer, consumer and admin clients to Kafka
  • add support for additional writer configuration in the Pulsar Sink
  • add End-To-End test (it uses a Push job, we could follow up with all the writer APIs)

How was this PR tested?

There is a new end-to-end test

Does this PR introduce any user-facing changes?

  • [N] No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@eolivelli
Copy link
Copy Markdown
Contributor Author

eolivelli commented May 29, 2023

All tests passed :-)

ZacAttack
ZacAttack approved these changes May 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ZacAttack ZacAttack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ZacAttack ZacAttack merged commit 9cb6f01 into linkedin:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZacAttack ZacAttack ZacAttack approved these changes

@FelixGV FelixGV FelixGV approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eolivelli @ZacAttack @FelixGV