[doc] update the documentation on testing#11
Merged
adamxchen merged 1 commit intolinkedin:masterfrom Sep 27, 2022
Merged
Conversation
sushantmane
approved these changes
Sep 27, 2022
eolivelli
pushed a commit
to eolivelli/venice
that referenced
this pull request
May 26, 2023
- Fix Venice Server loading Kafka SASL parameters - Remove JAAS configuration from PulsarSink tests, Kafka is not configured with SASL - Add a generic `writerConfig` to tune the PulsarSink
ZacAttack
pushed a commit
that referenced
this pull request
Jun 1, 2023
…ion with Kafka (#452) * [push-job] Fix VenicePushJob - loading Kafka configuration * [tests] Fix tests failing due to SASL implementation * [controller][server] Ensure that Kafka SASL properties are preserved (#10) * [samza][pulsar-sink] Pass SASL properties to the Producer * [server][pulsar-sink] More fixes about SASL authentication (#11) - Fix Venice Server loading Kafka SASL parameters - Remove JAAS configuration from PulsarSink tests, Kafka is not configured with SASL - Add a generic `writerConfig` to tune the PulsarSink * [tests] Add Kafka SASL integration tests end-to-end (#20) * Fix build * Fix build * Increase code coverage * fix test
13 tasks
misyel
added a commit
to misyel/venice
that referenced
this pull request
Apr 22, 2026
…opilot comments Adds `checkRollbackOriginVersionCapacityForNewPush` which rejects a new push while any ROLLED_BACK (or parent-side rollback-origin PARTIALLY_ONLINE) version is still within its retention window. The check runs on both the parent (`VeniceParentHelixAdmin.incrementVersionIdempotent`) and the child (`VeniceHelixAdmin.addVersion`), so the rejection surfaces synchronously to the VPJ instead of failing only in async admin-message consumption on the child. Integration tests cover both the block (within retention) and the release (after retention expires) paths. Also addresses Copilot comments on PR linkedin#2688: - linkedin#11 `assumeRolledBackIfUnreachable` is now empty for full-cluster rollbacks so unreachable regions don't inflate the ROLLED_BACK count. - linkedin#14 If the region filter contains only unknown regions, skip the parent status update instead of falling through into full-cluster behavior. - linkedin#15 If zero regions confirm ROLLED_BACK, leave parent status unchanged rather than downgrading to PARTIALLY_ONLINE on no evidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original guide suggests following the README to run tests but README doesn't contain any instruction of that. The updated instruction is located in the
workspace_setup.md