Skip to content

[server] Use interpolation for logging in venice-common#4

Merged
lluwm merged 1 commit intolinkedin:masterfrom
lluwm:master
Sep 26, 2022
Merged

[server] Use interpolation for logging in venice-common#4
lluwm merged 1 commit intolinkedin:masterfrom
lluwm:master

Conversation

@lluwm
Copy link
Copy Markdown
Contributor

@lluwm lluwm commented Sep 26, 2022

This rb mainly contains the logging clean ups for venice-common module.

How was this PR tested?

Internal CI (yellow)

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@lluwm lluwm requested a review from a team September 26, 2022 18:20
sushantmane
sushantmane previously approved these changes Sep 26, 2022
Copy link
Copy Markdown
Contributor

@sushantmane sushantmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lluwm lluwm changed the title [common] Use interpolation for logging in venice-common [server] Use interpolation for logging in venice-common Sep 26, 2022
@lluwm
Copy link
Copy Markdown
Contributor Author

lluwm commented Sep 26, 2022

Thanks Sushant. Updated the tag part.

@lluwm lluwm merged commit 21a884f into linkedin:master Sep 26, 2022
minhmo1620 pushed a commit to minhmo1620/venice that referenced this pull request Apr 2, 2025
# This is the 1st commit message:

Init setup for getSmallestVersion

# This is the commit message #2:

# Add http route

# This is the commit message #3:

# Comment out the standby broadcast

# This is the commit message linkedin#4:

# Rename the method

# This is the commit message linkedin#5:

# Update the validation

# This is the commit message linkedin#6:

# Update the comment

# This is the commit message linkedin#7:

# Update comments

# This is the commit message linkedin#8:

# Remove comments

# This is the commit message linkedin#9:

# Update imports
ymuppala added a commit to ymuppala/venice that referenced this pull request Feb 17, 2026
# This is the 1st commit message:

Add VALUE_SCHEMA_DIR for Spark TTL repush

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

# The commit message linkedin#2 will be skipped:

# Set SYSTEM_SCHEMA_READER_ENABLED in Spark KIF config
#
# Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

# The commit message linkedin#3 will be skipped:

# Preserve per-record schema ID in Spark repush
#
# Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

# The commit message linkedin#4 will be skipped:

# Track compression metrics in Spark KIF repush
#
# Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

# The commit message linkedin#5 will be skipped:

# Default SSL configurator to TempFileSSLConfigurator
#
# Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

# The commit message linkedin#6 will be skipped:

# Removing try with resources on spark context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants