[venice-common] Use interpolation format for logging for helix.#8
Merged
haoxu07 merged 5 commits intolinkedin:masterfrom Sep 27, 2022
Merged
[venice-common] Use interpolation format for logging for helix.#8haoxu07 merged 5 commits intolinkedin:masterfrom
haoxu07 merged 5 commits intolinkedin:masterfrom
Conversation
sushantmane
previously approved these changes
Sep 26, 2022
minhmo1620
pushed a commit
to minhmo1620/venice
that referenced
this pull request
Apr 2, 2025
# This is the 1st commit message: Init setup for getSmallestVersion # This is the commit message #2: # Add http route # This is the commit message #3: # Comment out the standby broadcast # This is the commit message linkedin#4: # Rename the method # This is the commit message linkedin#5: # Update the validation # This is the commit message linkedin#6: # Update the comment # This is the commit message linkedin#7: # Update comments # This is the commit message linkedin#8: # Remove comments # This is the commit message linkedin#9: # Update imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary, imperative, start upper case, don't end with a period
This rb mainly contains the logging clean ups for helix related code in venice-common module .
How was this PR tested?
Internal CI (yellow)
Does this PR introduce any user-facing changes?