[DMZ Test] Added integration test cases for DMZ in Advanced Settings#378
Merged
Merged
Conversation
Added integration test cases for DMZ in Advanced Settings
AustinChangLinksys
added a commit
that referenced
this pull request
Jun 16, 2026
* feat: support split SSID in PnP personalize WiFi step (#378) When the router ships with per-band SSIDs (split mode), the PnP setup now shows a separate WiFi name/password card per band instead of a single field that only reflected the first radio. - Add PnpWiFiSettings/PnpWiFiRadio model and replace getDefaultWiFiNameAndPassphrase() with getDefaultWiFiSettings(), which reads all radios from getRadioInfo and derives split vs unified mode. - PersonalWiFiStep renders per-band cards in split mode and validates all bands; unified mode keeps the existing single-field UI. - save() applies per-band ssid/passphrase in split mode and re-applies the authoritative per-band security from getRadioInfo so the network is not downgraded to open (which previously wiped the passphrase). - Pin the horizontal stepper's Back/Next controls below the scrollable content (PrivacyGUI-Widgets v1.2.9) so they stay visible with the taller multi-band content. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: PnP WiFi write uses SetRadioSettings instead of SetSimpleWiFiSettings Unifies the PnP save path with the WiFi settings page (wirelessap service). Build SetRadioSettings from the current getRadioInfo, overriding only ssid and wpaPersonalSettings.passphrase per band while preserving mode/channel/ channelWidth/broadcastSSID/security straight from the device. This removes the SetSimpleWiFiSettings security-downgrade workaround entirely: security is no longer re-derived (getSimpleWiFiSettings could report 'None'), it is carried over untouched, so no band can be downgraded to open. Verified on unconfigured hardware that SetRadioSettings is accepted before setDeviceMode {Master}; transaction ordering is unchanged. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: show per-band WiFi on PnP "ready" screen for split SSID The WiFi-ready screen previously only showed the primary (2.4GHz) credential, which was misleading on split-SSID routers where each band has a different SSID/password. - Split mode: render one compact horizontal card per band (QR + band name + SSID + password + print/download), headline shows "Your network is ready" (new loc string pnpNetworkReady) instead of a single band's SSID. - Unified mode: unchanged (large QR + password card, headline shows the SSID). - Pin the "Done" button at the bottom using the same bounded-height + scroll pattern as the stepper, content-aligned and without a divider, so it matches the Back/Next footer on the other PnP steps. - Add split-SSID "WiFi ready" localization test case. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * i18n: add pnpNetworkReady translations for all locales Translate the "Your network is ready" string (used on the PnP WiFi-ready screen in split-SSID mode) into all 25 supported locales. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
PeterJhongLinksys
pushed a commit
that referenced
this pull request
Jun 16, 2026
* fix: extract inline scripts to external JS for CSP compliance (#927) Move inline <script> blocks from index.html to early-bootstrap.js, enabling removal of 'unsafe-inline' from script-src CSP directive. Closes #926 Ref: linksys/LinksysWRT#352 Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * fix: replace parentheses with dash in language display names for RTL compatibility (#934) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * feat: support split SSID per band in PnP setup (#378) (#938) * feat: support split SSID in PnP personalize WiFi step (#378) When the router ships with per-band SSIDs (split mode), the PnP setup now shows a separate WiFi name/password card per band instead of a single field that only reflected the first radio. - Add PnpWiFiSettings/PnpWiFiRadio model and replace getDefaultWiFiNameAndPassphrase() with getDefaultWiFiSettings(), which reads all radios from getRadioInfo and derives split vs unified mode. - PersonalWiFiStep renders per-band cards in split mode and validates all bands; unified mode keeps the existing single-field UI. - save() applies per-band ssid/passphrase in split mode and re-applies the authoritative per-band security from getRadioInfo so the network is not downgraded to open (which previously wiped the passphrase). - Pin the horizontal stepper's Back/Next controls below the scrollable content (PrivacyGUI-Widgets v1.2.9) so they stay visible with the taller multi-band content. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: PnP WiFi write uses SetRadioSettings instead of SetSimpleWiFiSettings Unifies the PnP save path with the WiFi settings page (wirelessap service). Build SetRadioSettings from the current getRadioInfo, overriding only ssid and wpaPersonalSettings.passphrase per band while preserving mode/channel/ channelWidth/broadcastSSID/security straight from the device. This removes the SetSimpleWiFiSettings security-downgrade workaround entirely: security is no longer re-derived (getSimpleWiFiSettings could report 'None'), it is carried over untouched, so no band can be downgraded to open. Verified on unconfigured hardware that SetRadioSettings is accepted before setDeviceMode {Master}; transaction ordering is unchanged. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: show per-band WiFi on PnP "ready" screen for split SSID The WiFi-ready screen previously only showed the primary (2.4GHz) credential, which was misleading on split-SSID routers where each band has a different SSID/password. - Split mode: render one compact horizontal card per band (QR + band name + SSID + password + print/download), headline shows "Your network is ready" (new loc string pnpNetworkReady) instead of a single band's SSID. - Unified mode: unchanged (large QR + password card, headline shows the SSID). - Pin the "Done" button at the bottom using the same bounded-height + scroll pattern as the stepper, content-aligned and without a divider, so it matches the Back/Next footer on the other PnP steps. - Add split-SSID "WiFi ready" localization test case. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * i18n: add pnpNetworkReady translations for all locales Translate the "Your network is ready" string (used on the PnP WiFi-ready screen in split-SSID mode) into all 25 supported locales. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * chore: bump version to 1.2.14 (#944) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.