feat: support split SSID per band in PnP setup (#378)

[AustinChangLinksys]

Summary

Adds split-SSID support to the PnP "Personalize your WiFi" step. The setup now detects whether the router uses unified or split SSIDs and renders accordingly:

• Unified mode (all bands share the same SSID/password): single WiFi name/password field — unchanged.
• Split mode (bands have different SSID/password): a separate card per band (2.4 GHz / 5 GHz / 6 GHz), each with its own name/password field and validation.

Related

• Closes [Du] Support split SSID per band in PnP setup flow #935
• Firmware: linksys/LinksysWRT#378 (requirement), linksys/LinksysWRT#384 (GetRadioInfo3 6 GHz read-back bug)

Changes

• New model PnpWiFiSettings / PnpWiFiRadio (lib/page/instant_setup/data/pnp_wifi_settings.dart). primaryRadio prioritizes 2.4 GHz, falls back to first radio.
• pnp_provider.dart: replaced getDefaultWiFiNameAndPassphrase() with getDefaultWiFiSettings(), reading all radios from getRadioInfo and deriving split vs unified mode.
• save(): applies per-band ssid/passphrase in split mode; always re-applies the authoritative per-band security from getRadioInfo (since getSimpleWiFiSettings can report security: "None", which would downgrade the network to open and wipe the passphrase). isWiFiChanged diffs each band's edited values against current router values to avoid redundant writes.
• PersonalWiFiStep: per-band TextEditingControllers created/disposed by mode; all bands validated before enabling Next.
• Call sites (pnp_setup_view.dart, pnp_admin_view.dart) use getDefaultWiFiSettings().primaryRadio.
• Stepper (PrivacyGUI-Widgets v1.2.9): Back/Next controls pinned below the scrollable content so they stay visible with the taller multi-band content.

Testing

• Unified mode: displays correctly, save works. ✅
• Split mode: displays per-band cards correctly, save works. ✅
• Known limitation: the 6 GHz SSID may display incorrectly on read-back due to the firmware bug linksys/LinksysWRT#384 (GetRadioInfo3 returns the 5 GHz SSID for 6 GHz). Values written via SetSimpleWiFiSettings are correct.
• flutter analyze clean (only pre-existing warnings); PnP localization tests pass.

🤖 Generated with Claude Code

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

[PeterJhongLinksys]

Code Review

Overall the split/unified mode branching is clean and the security re-application from getRadioInfo is the right call to prevent accidental downgrade.

A few notes:

1. checkAdminPassword receives nullable password — In save() at line 631, defaultWiFiSettings.primaryRadio?.password can be null when radios is empty (early return path). Confirm checkAdminPassword(null) is safe or add a ?? '' fallback like the admin view does.

2. Split-mode detection includes first radio in comparison — The pnpRadios.any(...) check compares all radios including the first against itself (always false for that element). Semantically .skip(1).any(...) is more precise, though the result is the same.

3. Backward-compat keys in onNext for split mode — 'ssid' and 'password' are emitted alongside 'perBandSettings' but save() never reads them in the split path. If no other consumer exists, consider removing to avoid confusion.

4. Disabled radios — PnpWiFiRadio.isEnabled is stored but the UI renders all bands regardless. Is this intentional (show all bands during PnP) or should disabled radios be filtered out?

Otherwise LGTM 👍

[PeterJhongLinksys]

Looks good to me

[AustinChangLinksys]

Update — scope expanded beyond the initial split-SSID display

Since the original PR, the following changes were added based on testing and review. Full commit list:

1. 30cdeef1 — feat: support split SSID in PnP personalize WiFi step (original)
2. 0b362ce7 — refactor: PnP WiFi write uses SetRadioSettings instead of SetSimpleWiFiSettings
3. b0a632de — feat: show per-band WiFi on PnP "ready" screen for split SSID
4. ef2c5a2a — i18n: add pnpNetworkReady translations for all locales

2. SetRadioSettings migration (pnp_provider.dart)

The PnP save now writes WiFi via SetRadioSettings (wirelessap service) instead of SetSimpleWiFiSettings, unifying the write path with the WiFi settings page. It builds the payload from the current getRadioInfo, overriding only ssid + wpaPersonalSettings.passphrase per band and preserving mode/channel/channelWidth/broadcastSSID/security straight from the device.

This removes the previous security re-derivation workaround entirely — security is carried over untouched, so no band can be downgraded to open (the bug where getSimpleWiFiSettings reported security: "None"). Verified on unconfigured hardware that SetRadioSettings is accepted before setDeviceMode {Master}; transaction ordering is unchanged.

3. "Your network is ready" screen (pnp_setup_view.dart)

Previously this screen only showed the primary (2.4GHz) credential, which was misleading on split-SSID routers.

• Split mode: one compact horizontal card per band (QR + band name + SSID + password + print/download); headline shows "Your network is ready" instead of a single band's SSID.
• Unified mode: unchanged (large QR + password card, headline shows the SSID).
• Done button pinned at the bottom using the same bounded-height + scroll pattern as the stepper, content-aligned and without a divider, so it matches the Back/Next footer on the other PnP steps.

4. Localization

New string pnpNetworkReady ("Your network is ready") translated into all 25 supported locales.

Testing

• Unified + split modes: display and save both verified on device (the only outstanding item is the firmware 6 GHz read-back bug linksys/LinksysWRT#384, mitigated as a side effect of reading back through the wirelessap settings the device actually applied).
• flutter analyze clean (pre-existing warnings only); PnP localization tests pass (15 cases incl. split-SSID personalize + WiFi-ready).

Dependency

Requires PrivacyGUI-Widgets v1.2.9 (submodule pointer updated) — pins the horizontal stepper's Back/Next controls below the scrollable content.