Skip to content

fix: update Japanese translations for improved accuracy and consistency#685

Merged
PeterJhongLinksys merged 1 commit into
dev-1.2.9from
hotfix/update-ja-translations
Mar 16, 2026
Merged

fix: update Japanese translations for improved accuracy and consistency#685
PeterJhongLinksys merged 1 commit into
dev-1.2.9from
hotfix/update-ja-translations

Conversation

@AustinChangLinksys

Copy link
Copy Markdown
Collaborator

Summary

Update Japanese (ja) translations in app_ja.arb for improved accuracy and natural phrasing.

Changes

  • Refined 199 translation entries for better accuracy and consistency
  • Removed unnecessary verb endings (e.g. 「する」) for UI button labels
  • Corrected terminology (e.g. メーター → メートル)
  • Improved natural phrasing throughout the translation file

@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Update Japanese translations for accuracy and consistency

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Refined 199 Japanese translation entries for improved accuracy
• Removed unnecessary verb endings from UI button labels
• Corrected terminology (e.g., メーター → メートル)
• Improved natural phrasing and consistency throughout
Diagram
flowchart LR
  A["Japanese ARB File"] -- "Refine entries" --> B["Improved Accuracy"]
  A -- "Remove verb endings" --> C["Cleaner UI Labels"]
  A -- "Fix terminology" --> D["Correct Terms"]
  A -- "Natural phrasing" --> E["Better UX"]
  B --> F["Updated app_ja.arb"]
  C --> F
  D --> F
  E --> F
Loading

Grey Divider

File Changes

1. lib/l10n/app_ja.arb 🐞 Bug fix +199/-199

Refine 199 Japanese translation entries

• Removed unnecessary verb endings (する) from action labels like addDHCPReservation, addDns,
 addNodes, addStaticRoute
• Corrected terminology: メーター → メートル in addNodesDesc
• Improved phrasing: メッシュWi-Fi → メッシュWiFi, 待機時間 → 待ち時間
• Enhanced natural language: replaced awkward constructions with more natural Japanese expressions
• Standardized spacing in compound terms: ブロードキャスト SSID → ブロードキャストSSID, デフォルト ゲートウェイ → デフォルトゲートウェイ
• Updated feature names with English labels: Client Steering, MLO, Instant-Privacy, Node Steering
• Refined technical descriptions for better clarity and consistency

lib/l10n/app_ja.arb


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented Mar 16, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Action required

1. Factory reset scope unclear 🐞 Bug ✓ Correctness
Description
factoryResetParentTitle was changed to no longer mention “parent”, making it nearly
indistinguishable from factoryResetChildTitle even though the UI selects between them for
different reset scopes. This can cause Japanese users to confirm the wrong destructive factory reset
(parent+all children vs a single node subtree) because the dialog message is generic and the title
is the primary scope cue.
Code

lib/l10n/app_ja.arb[209]

+  "factoryResetParentTitle": "ノードとそのすべての子ノードを工場出荷時設定にリセットする",
Evidence
The factory reset dialog title is chosen based on whether the target is a master/parent or a child
node, and the English template clearly distinguishes these two titles. In Japanese, both titles now
start with “ノードとそのすべての子ノード…”, removing the explicit “Parent” cue even though the dialog does not
otherwise include the node role/name in the title/message.

lib/l10n/app_ja.arb[205-210]
lib/page/components/shortcuts/dialogs.dart[401-420]
lib/l10n/app_en.arb[398-403]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`factoryResetParentTitle` in `app_ja.arb` no longer communicates that the reset is for the **parent/master** node (and its children). The UI selects between `factoryResetParentTitle` and `factoryResetChildTitle` for different scopes, so Japanese users lose a critical cue for a destructive action.

## Issue Context
The factory reset confirmation dialog uses a generic description message and relies heavily on the *title* to indicate which scope is being reset.

## Fix Focus Areas
- lib/l10n/app_ja.arb[205-210]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

Comment thread lib/l10n/app_ja.arb
"factoryResetOk": "はい、すべてを工場出荷時設定にリセットします。",
"factoryResetOkSingle": "工場出荷状態へのリセットが完了しました",
"factoryResetParentTitle": "親とそのすべての子ノードを工場出荷時設定にリセットする",
"factoryResetParentTitle": "ノードとそのすべての子ノードを工場出荷時設定にリセットする",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Factory reset scope unclear 🐞 Bug ✓ Correctness

factoryResetParentTitle was changed to no longer mention “parent”, making it nearly
indistinguishable from factoryResetChildTitle even though the UI selects between them for
different reset scopes. This can cause Japanese users to confirm the wrong destructive factory reset
(parent+all children vs a single node subtree) because the dialog message is generic and the title
is the primary scope cue.
Agent Prompt
## Issue description
`factoryResetParentTitle` in `app_ja.arb` no longer communicates that the reset is for the **parent/master** node (and its children). The UI selects between `factoryResetParentTitle` and `factoryResetChildTitle` for different scopes, so Japanese users lose a critical cue for a destructive action.

## Issue Context
The factory reset confirmation dialog uses a generic description message and relies heavily on the *title* to indicate which scope is being reset.

## Fix Focus Areas
- lib/l10n/app_ja.arb[205-210]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: update Japanese translations for improved accuracy and consistency

2 participants