fix: update Japanese translations for improved accuracy and consistency#685
Merged
Merged
Conversation
Review Summary by QodoUpdate Japanese translations for accuracy and consistency
WalkthroughsDescription• Refined 199 Japanese translation entries for improved accuracy • Removed unnecessary verb endings from UI button labels • Corrected terminology (e.g., メーター → メートル) • Improved natural phrasing and consistency throughout Diagramflowchart LR
A["Japanese ARB File"] -- "Refine entries" --> B["Improved Accuracy"]
A -- "Remove verb endings" --> C["Cleaner UI Labels"]
A -- "Fix terminology" --> D["Correct Terms"]
A -- "Natural phrasing" --> E["Better UX"]
B --> F["Updated app_ja.arb"]
C --> F
D --> F
E --> F
File Changes1. lib/l10n/app_ja.arb
|
Code Review by Qodo
1. Factory reset scope unclear
|
| "factoryResetOk": "はい、すべてを工場出荷時設定にリセットします。", | ||
| "factoryResetOkSingle": "工場出荷状態へのリセットが完了しました", | ||
| "factoryResetParentTitle": "親とそのすべての子ノードを工場出荷時設定にリセットする", | ||
| "factoryResetParentTitle": "ノードとそのすべての子ノードを工場出荷時設定にリセットする", |
There was a problem hiding this comment.
1. Factory reset scope unclear 🐞 Bug ✓ Correctness
factoryResetParentTitle was changed to no longer mention “parent”, making it nearly indistinguishable from factoryResetChildTitle even though the UI selects between them for different reset scopes. This can cause Japanese users to confirm the wrong destructive factory reset (parent+all children vs a single node subtree) because the dialog message is generic and the title is the primary scope cue.
Agent Prompt
## Issue description
`factoryResetParentTitle` in `app_ja.arb` no longer communicates that the reset is for the **parent/master** node (and its children). The UI selects between `factoryResetParentTitle` and `factoryResetChildTitle` for different scopes, so Japanese users lose a critical cue for a destructive action.
## Issue Context
The factory reset confirmation dialog uses a generic description message and relies heavily on the *title* to indicate which scope is being reset.
## Fix Focus Areas
- lib/l10n/app_ja.arb[205-210]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
PeterJhongLinksys
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Japanese (ja) translations in
app_ja.arbfor improved accuracy and natural phrasing.Changes