fix: update Japanese translations for improved accuracy and naturalness#748
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan Review Summary by QodoUpdate Japanese translations for accuracy and consistency
WalkthroughsDescription• Updated Japanese translations for improved accuracy and naturalness • Unified "Instant-Safety" translation to "セーフティー" for consistency • Improved feature descriptions for clarity and user understanding • Corrected geographical name translations for accuracy • Removed unused speedTestFailedToLoadServers localization key Diagramflowchart LR
A["Japanese Translations<br/>app_ja.arb"] -->|Unify terminology| B["Instant-Safety<br/>→ セーフティー"]
A -->|Improve descriptions| C["Feature Descriptions<br/>Privacy, Devices, Topology"]
A -->|Correct geography| D["Location Names<br/>Western Australia, Kwajalein"]
A -->|Remove unused| E["Delete speedTestFailedToLoadServers"]
File Changes1. lib/l10n/app_ja.arb
|
Code Review by Qodo
1. Removed key still referenced
|
Comment on lines
716
to
724
| "speedOkayDescription": "この速度であれば、HD動画のストリーミングやオンラインゲームを利用できます。複数のデバイスが同時にインターネットを使用している場合は、速度低下やバッファリングが発生する可能性があります。", | ||
| "speedOptimal": "通信速度:最適", | ||
| "speedOptimalDescription": "この速度なら、複数のデバイスでさまざまなインターネットアプリケーションを利用しながら、HD動画のストリーミングやオンラインゲームを同時に楽しめます。", | ||
| "speedTestFailedToLoadServers": "サーバーリストの読み込みに失敗しました", | ||
| "speedTest": "スピードテスト", | ||
| "speedTestDesc": "速度を確認する方法は2つあります。", | ||
| "speedTestExternalCloudFlare": "Cloudflareでテスト", | ||
| "speedTestExternalDesc": "外部サービスで速度をテストする前に:", | ||
| "speedTestExternalDesc": "外部サービスで速度をテストする前に", | ||
| "speedTestExternalFast": "Fast.comでテスト", | ||
| "speedTestExternalOthers": "または、お好みのサービスをご利用ください。", |
There was a problem hiding this comment.
1. Removed key still referenced 🐞 Bug ✓ Correctness
The PR removes the Japanese translation key speedTestFailedToLoadServers, but the Speed Test UI still calls loc(context).speedTestFailedToLoadServers when the server list fails to load. This will cause a missing localization (fallback text or a runtime failure, depending on gen-l10n behavior) for Japanese users in that error state.
Agent Prompt
### Issue description
`lib/l10n/app_ja.arb` removes the `speedTestFailedToLoadServers` key, but UI code still calls `loc(context).speedTestFailedToLoadServers` when server loading fails.
### Issue Context
This is used in the speed test error state (`state.serversError`). Removing the JA entry makes Japanese locale incomplete for that state.
### Fix Focus Areas
- lib/l10n/app_ja.arb[716-724]
- lib/page/health_check/views/speed_test_view.dart[225-233]
### What to change
Choose one:
1) Re-add `"speedTestFailedToLoadServers": "..."` to `app_ja.arb` (recommended).
2) If the message is truly unused, remove/replace the UI reference in `speed_test_view.dart` and ensure the error state still shows an appropriate message.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
PeterJhongLinksys
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instantPrivacyDesc,instantTopologyDesc,instantVerifyDesc)speedTestFailedToLoadServerskeyTest plan
🤖 Generated with Claude Code