Skip to content

fix: update Japanese translations for improved accuracy and naturalness#748

Merged
PeterJhongLinksys merged 1 commit into
dev-1.2.9from
fix/update-japanese-translations
Mar 24, 2026
Merged

fix: update Japanese translations for improved accuracy and naturalness#748
PeterJhongLinksys merged 1 commit into
dev-1.2.9from
fix/update-japanese-translations

Conversation

@AustinChangLinksys

Copy link
Copy Markdown
Collaborator

Summary

  • Unified「Instant-Safety」translation to「セーフティー」for consistency
  • Improved naturalness and accuracy of feature descriptions (e.g., instantPrivacyDesc, instantTopologyDesc, instantVerifyDesc)
  • Corrected geographical name translations (「西オーストラリア州」→「オーストラリア西部」、「クェゼリン」→「クワジェリン」)
  • Removed unused speedTestFailedToLoadServers key

Test plan

  • Verify Japanese locale renders correctly on all affected screens
  • Confirm no missing or broken localization keys

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@qodo-code-review

Copy link
Copy Markdown
ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

Review Summary by Qodo

Update Japanese translations for accuracy and consistency

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Updated Japanese translations for improved accuracy and naturalness
• Unified "Instant-Safety" translation to "セーフティー" for consistency
• Improved feature descriptions for clarity and user understanding
• Corrected geographical name translations for accuracy
• Removed unused speedTestFailedToLoadServers localization key
Diagram
flowchart LR
  A["Japanese Translations<br/>app_ja.arb"] -->|Unify terminology| B["Instant-Safety<br/>→ セーフティー"]
  A -->|Improve descriptions| C["Feature Descriptions<br/>Privacy, Devices, Topology"]
  A -->|Correct geography| D["Location Names<br/>Western Australia, Kwajalein"]
  A -->|Remove unused| E["Delete speedTestFailedToLoadServers"]
Loading

Grey Divider

File Changes

1. lib/l10n/app_ja.arb Localization +13/-14

Improve Japanese localization accuracy and consistency

• Unified "Instant-Safety" terminology from "保護" to "セーフティー" across multiple keys
• Enhanced feature descriptions for instantPrivacyDesc, instantDevicesDesc,
 instantTopologyDesc, and instantVerifyDesc with more detailed and accurate information
• Corrected geographical translations: "西オーストラリア州" → "オーストラリア西部" and "クェゼリン" → "クワジェリン"
• Removed unused speedTestFailedToLoadServers key and refined related speed test descriptions
• Updated various UI strings for improved naturalness and clarity in Japanese

lib/l10n/app_ja.arb


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented Mar 24, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)

Grey Divider


Action required

1. Removed key still referenced 🐞 Bug ✓ Correctness
Description
The PR removes the Japanese translation key speedTestFailedToLoadServers, but the Speed Test UI
still calls loc(context).speedTestFailedToLoadServers when the server list fails to load. This will
cause a missing localization (fallback text or a runtime failure, depending on gen-l10n behavior)
for Japanese users in that error state.
Code

lib/l10n/app_ja.arb[R716-724]

  "speedOkayDescription": "この速度であれば、HD動画のストリーミングやオンラインゲームを利用できます。複数のデバイスが同時にインターネットを使用している場合は、速度低下やバッファリングが発生する可能性があります。",
  "speedOptimal": "通信速度:最適",
  "speedOptimalDescription": "この速度なら、複数のデバイスでさまざまなインターネットアプリケーションを利用しながら、HD動画のストリーミングやオンラインゲームを同時に楽しめます。",
-  "speedTestFailedToLoadServers": "サーバーリストの読み込みに失敗しました",
  "speedTest": "スピードテスト",
  "speedTestDesc": "速度を確認する方法は2つあります。",
  "speedTestExternalCloudFlare": "Cloudflareでテスト",
-  "speedTestExternalDesc": "外部サービスで速度をテストする前に:",
+  "speedTestExternalDesc": "外部サービスで速度をテストする前に",
  "speedTestExternalFast": "Fast.comでテスト",
  "speedTestExternalOthers": "または、お好みのサービスをご利用ください。",
Evidence
In this PR, app_ja.arb deletes the key "speedTestFailedToLoadServers". However, the Speed Test view
still renders that string when state.serversError is true. Also, the template file app_en.arb still
contains the key, meaning gen-l10n expects it as part of AppLocalizations and the Japanese locale
will be missing that translation after this change.

lib/page/health_check/views/speed_test_view.dart[225-233]
lib/l10n/app_en.arb[908-916]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`lib/l10n/app_ja.arb` removes the `speedTestFailedToLoadServers` key, but UI code still calls `loc(context).speedTestFailedToLoadServers` when server loading fails.

### Issue Context
This is used in the speed test error state (`state.serversError`). Removing the JA entry makes Japanese locale incomplete for that state.

### Fix Focus Areas
- lib/l10n/app_ja.arb[716-724]
- lib/page/health_check/views/speed_test_view.dart[225-233]

### What to change
Choose one:
1) Re-add `"speedTestFailedToLoadServers": "..."` to `app_ja.arb` (recommended).
2) If the message is truly unused, remove/replace the UI reference in `speed_test_view.dart` and ensure the error state still shows an appropriate message.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

Comment thread lib/l10n/app_ja.arb
Comment on lines 716 to 724
"speedOkayDescription": "この速度であれば、HD動画のストリーミングやオンラインゲームを利用できます。複数のデバイスが同時にインターネットを使用している場合は、速度低下やバッファリングが発生する可能性があります。",
"speedOptimal": "通信速度:最適",
"speedOptimalDescription": "この速度なら、複数のデバイスでさまざまなインターネットアプリケーションを利用しながら、HD動画のストリーミングやオンラインゲームを同時に楽しめます。",
"speedTestFailedToLoadServers": "サーバーリストの読み込みに失敗しました",
"speedTest": "スピードテスト",
"speedTestDesc": "速度を確認する方法は2つあります。",
"speedTestExternalCloudFlare": "Cloudflareでテスト",
"speedTestExternalDesc": "外部サービスで速度をテストする前に:",
"speedTestExternalDesc": "外部サービスで速度をテストする前に",
"speedTestExternalFast": "Fast.comでテスト",
"speedTestExternalOthers": "または、お好みのサービスをご利用ください。",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Removed key still referenced 🐞 Bug ✓ Correctness

The PR removes the Japanese translation key speedTestFailedToLoadServers, but the Speed Test UI
still calls loc(context).speedTestFailedToLoadServers when the server list fails to load. This will
cause a missing localization (fallback text or a runtime failure, depending on gen-l10n behavior)
for Japanese users in that error state.
Agent Prompt
### Issue description
`lib/l10n/app_ja.arb` removes the `speedTestFailedToLoadServers` key, but UI code still calls `loc(context).speedTestFailedToLoadServers` when server loading fails.

### Issue Context
This is used in the speed test error state (`state.serversError`). Removing the JA entry makes Japanese locale incomplete for that state.

### Fix Focus Areas
- lib/l10n/app_ja.arb[716-724]
- lib/page/health_check/views/speed_test_view.dart[225-233]

### What to change
Choose one:
1) Re-add `"speedTestFailedToLoadServers": "..."` to `app_ja.arb` (recommended).
2) If the message is truly unused, remove/replace the UI reference in `speed_test_view.dart` and ensure the error state still shows an appropriate message.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@PeterJhongLinksys
PeterJhongLinksys merged commit 9ace9bb into dev-1.2.9 Mar 24, 2026
@PeterJhongLinksys
PeterJhongLinksys deleted the fix/update-japanese-translations branch March 24, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: update Japanese translations for improved accuracy and consistency

2 participants