Skip to content

Release 1.2.13#911

Merged
HankYuLinksys merged 2 commits into
mainfrom
dev-1.2.13
Jun 1, 2026
Merged

Release 1.2.13#911
HankYuLinksys merged 2 commits into
mainfrom
dev-1.2.13

Conversation

@AustinChangLinksys

Copy link
Copy Markdown
Collaborator

Summary

Related Issues

Test plan

  • Verified idle timeout extended to 15 minutes
  • Build verification

🤖 Generated with Claude Code

AustinChangLinksys and others added 2 commits May 26, 2026 09:28
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Addresses Issue #4. Field installers were being logged out 3-4 times during
typical installation workflows under the previous 5-minute idle timeout.
15 minutes is a more typical value for this kind of admin UI.

Note: cloud session tokens auto-refresh on expiry and are not affected
by this change. The idle timer is the only mechanism currently forcing
re-authentication during a normal session.
@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Extend UI idle timeout to 15 minutes and release 1.2.13

🐞 Bug fix ✨ Enhancement

Grey Divider

Walkthroughs

Description
• Extend UI idle timeout from 5 to 15 minutes
• Prevents field installers from premature logout
• Aligns with typical admin UI timeout standards
• Bump version to 1.2.13
Diagram
flowchart LR
  A["Idle Timeout Configuration"] -- "increased from 5 to 15 minutes" --> B["IdleChecker Component"]
  B -- "reduces premature logouts" --> C["Better User Experience"]
  D["Version Update"] -- "1.2.12 to 1.2.13" --> E["Release 1.2.13"]

Loading

Grey Divider

File Changes

1. lib/page/components/layouts/root_container.dart 🐞 Bug fix +1/-1

Increase idle timeout duration to 15 minutes

• Updated IdleChecker widget idle timeout duration
• Changed from 5 minutes to 15 minutes
• Addresses issue where field installers were logged out prematurely

lib/page/components/layouts/root_container.dart


2. pubspec.yaml ⚙️ Configuration changes +1/-1

Bump version to 1.2.13

• Bumped application version from 1.2.12 to 1.2.13
• Updated build number remains at 100000

pubspec.yaml


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented Jun 1, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Context used

Grey Divider


Advisory comments

1. Hard-coded idle timeout 🐞 Bug ⚙ Maintainability
Description
AppRootContainer hard-codes the UI idle timeout value (Duration(minutes: 15)) at the callsite,
making future adjustments harder to discover and more error-prone if other flows later need to align
to the same timeout. Centralizing this as a named constant/config reduces future maintenance risk
without changing behavior.
Code

lib/page/components/layouts/root_container.dart[R47-48]

Evidence
The root container passes a literal duration into a reusable IdleChecker widget. The codebase
already has a pattern for centralizing configuration-like values in BuildConfig, so centralizing
the idle timeout similarly would improve maintainability without changing runtime behavior.

lib/page/components/layouts/root_container.dart[46-53]
lib/page/components/layouts/idle_checker.dart[9-19]
lib/constants/build_config.dart[38-53]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The UI idle timeout is currently passed as a literal `Duration(minutes: 15)` from `AppRootContainer`, which makes future updates harder to track and increases the chance of inconsistent timeouts if the app later introduces more idle-sensitive flows.

### Issue Context
`IdleChecker` is a reusable widget that already takes `idleTime` as a parameter; the root container is the single place wiring this value today.

### Fix Focus Areas
- lib/page/components/layouts/root_container.dart[46-49]
- lib/page/components/layouts/idle_checker.dart[9-19]
- lib/constants/build_config.dart[38-53]

### Suggested change (one option)
1. Define a named constant for the idle timeout (e.g., `const kUiIdleTimeout = Duration(minutes: 15);`) in an appropriate shared location (either alongside `IdleChecker`, or in a config/constants file).
2. Replace the literal in `AppRootContainer` with the constant.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@HankYuLinksys HankYuLinksys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@HankYuLinksys
HankYuLinksys merged commit 2850900 into main Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release 1.2.13 [M60/M62] UI session timeout too short - forcing multiple logins during installation

2 participants