fix: [M3-7149] - Fix textfield tooltip icon focus area#10938
Merged
hana-akamai merged 2 commits intolinode:developfrom Sep 17, 2024
Merged
fix: [M3-7149] - Fix textfield tooltip icon focus area#10938hana-akamai merged 2 commits intolinode:developfrom
hana-akamai merged 2 commits intolinode:developfrom
Conversation
hkhalil-akamai
commented
Sep 13, 2024
Comment on lines
+482
to
+485
| height: '34px', | ||
| margin: '0px 0px 0px 4px', | ||
| padding: '6px', | ||
| padding: '17px', | ||
| width: '34px', |
Contributor
Author
There was a problem hiding this comment.
Specifying these as numbers instead of '__px' changes the appearance of the tooltip icon
hkhalil-akamai
requested review from
carrillo-erik and
hana-akamai
and removed request for
a team
hana-akamai
approved these changes
Sep 16, 2024
carrillo-erik
approved these changes
Sep 17, 2024
coliu-akamai
added
Approved
This was referenced Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixes the focus area for tooltips to be a circle rather than an oval as before.
Preview 📷
How to test 🧪
Verify textfield tooltips' focus areas render as a circle and otherwise work as before.