Skip to content

fix: [M3-7149] - Fix textfield tooltip icon focus area #10938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hana-akamai merged 2 commits into from
Sep 17, 2024
Merged

fix: [M3-7149] - Fix textfield tooltip icon focus area #10938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1da4635
Fix tooltip focus area
hkhalil-akamai Sep 13, 2024
5992294
Added changeset: Textarea tooltip icon focus area
hkhalil-akamai Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-10938-fixed-1726262803311.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

Textarea tooltip icon focus area ([#10938](https://github.com/linode/manager/pull/10938))
15 changes: 8 additions & 7 deletions packages/manager/src/components/TextField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import KeyboardArrowDown from '@mui/icons-material/KeyboardArrowDown';
import { Theme, useTheme } from '@mui/material/styles';
import {
default as _TextField,
StandardTextFieldProps,
} from '@mui/material/TextField';
import { useTheme } from '@mui/material/styles';
import { default as _TextField } from '@mui/material/TextField';
import { clamp } from 'ramda';
import * as React from 'react';
import { makeStyles } from 'tss-react/mui';
Expand All @@ -13,11 +10,13 @@ import { CircleProgress } from 'src/components/CircleProgress';
import { FormHelperText } from 'src/components/FormHelperText';
import { InputAdornment } from 'src/components/InputAdornment';
import { InputLabel } from 'src/components/InputLabel';
import { TooltipProps } from 'src/components/Tooltip';
import { TooltipIcon } from 'src/components/TooltipIcon';
import { convertToKebabCase } from 'src/utilities/convertToKebobCase';

import type { Theme } from '@mui/material/styles';
import type { StandardTextFieldProps } from '@mui/material/TextField';
import type { BoxProps } from 'src/components/Box';
import type { TooltipProps } from 'src/components/Tooltip';

const useStyles = makeStyles()((theme: Theme) => ({
absolute: {
Expand Down Expand Up @@ -480,8 +479,10 @@ export const TextField = (props: TextFieldProps) => {
{tooltipText && (
<TooltipIcon
sxTooltipIcon={{
height: '34px',
margin: '0px 0px 0px 4px',
padding: '6px',
padding: '17px',
width: '34px',
Comment on lines +482 to +485
Copy link
Contributor Author

@hkhalil-akamai hkhalil-akamai Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifying these as numbers instead of '__px' changes the appearance of the tooltip icon

}}
classes={{ popper: tooltipClasses }}
onMouseEnter={tooltipOnMouseEnter}
Expand Down