upcoming: [DPS-33693] Destination form - existing destination mode, GET destinations #12559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mduda-akamai
force-pushed
the
feature/DPS-33693-destination-form-existing-destination-mode-get-destinations
branch
from
1acc612 to
0ec8442
Compare
mduda-akamai
requested review from
hana-akamai and
harsh-akamai
and removed request for
a team
mduda-akamai
force-pushed
the
feature/DPS-33693-destination-form-existing-destination-mode-get-destinations
branch
from
0ec8442 to
16b937c
Compare
…ng-destination-mode-get-destinations
4 tasks
…ng-destination-mode-get-destinations # Conflicts: # packages/manager/src/features/DataStream/Streams/StreamCreate/Delivery/StreamCreateDelivery.test.tsx # packages/manager/src/features/DataStream/Streams/StreamCreate/Delivery/StreamCreateDelivery.tsx # packages/manager/src/features/DataStream/Streams/StreamCreate/StreamCreate.tsx
hana-akamai
approved these changes
Aug 1, 2025
| ); | ||
|
|
||
| expect( | ||
| within(screen.getByText('Host:').closest('div')!).getByText('test host') |
Contributor
There was a problem hiding this comment.
Can we just do
expect(screen.getByText('test host')).toBeVisible();
| ).toBeInTheDocument(); | ||
|
|
||
| expect( | ||
| within(screen.getByText('Bucket:').closest('div')!).getByText( |
|
|
||
| await waitFor(() => { | ||
| expect( | ||
| within(screen.getByText('Region:').closest('div')!).getByText( |
harsh-akamai
approved these changes
Aug 4, 2025
Contributor
harsh-akamai
left a comment
harsh-akamai
left a comment
There was a problem hiding this comment.
Thanks @mduda-akamai!
harsh-akamai
added
Approved
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts" |
|||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
DataStream: destination form - existing destination mode, GET destinations
Changes 🔄
/monitor/streams/destinations,/monitor/streams/destinations/:id)Target release date 🗓️
August 2025
Preview 📷
How to test 🧪
Prerequisites
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
➕ Adding a changeset
🧪 Providing/improving test coverage
📱 Providing mobile support
As an Author, before moving this PR from Draft to Open, I confirmed ✅