Skip to content

Conversation

@mduda-akamai
Copy link
Contributor

Description 📝

Cleanup docs and costs - they won't be ready for the beta release.

Changes 🔄

  • Remove Getting started guides
  • Remove all Docs links from Stream Create form
  • Replace the StreamCreateCheckoutBar with a new StreamCreateSubmitBar which doesn't have the price section

Target release date 🗓️

August 2025

Preview 📷

Before After
before 1 after 1
before 2 after 2

How to test 🧪

Verification steps

  • in datastream/streams/create
    • check if the right submit section behaves correctly
    • check if Docs link is visible in Cllusters and Delivery sections
  • check if Getting started guides are not visible in datastream/streams and datastream/destinations
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
📱 Providing mobile support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mduda-akamai mduda-akamai force-pushed the feature/DPS-34204-DataStream-cleanup-docs-and-costs branch from 069be5e to a787042 Compare July 24, 2025 12:42
@mduda-akamai mduda-akamai marked this pull request as ready for review July 24, 2025 12:53
@mduda-akamai mduda-akamai requested a review from a team as a code owner July 24, 2025 12:53
@mduda-akamai mduda-akamai requested review from harsh-akamai and mjac0bs and removed request for a team July 24, 2025 12:53
@mduda-akamai mduda-akamai self-assigned this Jul 24, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing689 Passing4 Skipped128m 6s

Details

Failing Tests
SpecTest
timerange-verification.spec.tsCloud Manager Cypress Tests→Integration tests for verifying Cloudpulse custom and preset configurations » Integration tests for verifying Cloudpulse custom and preset configurations

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/cloudpulse/timerange-verification.spec.ts"

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good --

✅ Confirmed no docs links in create flow or getting starting guides on landing pages
✅ Confirmed no pricing in sidebar
✅ Confirmed I can press submit and create a mock Stream (❓ : it doesn't look like we have mocks CRUD mode support for Destinations yet - will that be a forthcoming PR?)

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jul 25, 2025
@mduda-akamai
Copy link
Contributor Author

mduda-akamai commented Jul 28, 2025

@mjac0bs

(❓ : it doesn't look like we have mocks CRUD mode support for Destinations yet - will that be a forthcoming PR?)

Yes, GETs for Destinations are already waiting for review in #12559, POST will be done in another ticket

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed docs links are gone from streams/destinations landing pages (note: had to use CRUD MSW to be able to see the Streams landing page without an error)
✅ no pricing in checkout for Streams
✅ no docs link in Cluster/Delivery sections of Streams Create
✅ Created a stream (using MSW)

thanks @mduda-akamai!

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jul 29, 2025
@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jul 29, 2025
@mikeZuber-akamai mikeZuber-akamai merged commit 31574cc into linode:develop Jul 30, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Logs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants