Skip to content

fix: [UIE-10522] - Disable credential buttons for resuming state#13505

Merged
hana-akamai merged 8 commits intolinode:developfrom
hana-akamai:fix-dbaas-suspended-resume-loading-states
Mar 23, 2026
Merged

fix: [UIE-10522] - Disable credential buttons for resuming state#13505
hana-akamai merged 8 commits intolinode:developfrom
hana-akamai:fix-dbaas-suspended-resume-loading-states

Conversation

@hana-akamai
Copy link
Contributor

@hana-akamai hana-akamai commented Mar 17, 2026

Description 📝

Disable buttons to get credentials when the Database cluster is resuming

Changes 🔄

  • Add resuming to disabled states
  • Add disabledReason prop to CopyTooltip
  • Disable copy icon button in the Service URI field

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Next release

Preview 📷

Before After
image image
image image

How to test 🧪

Prerequisites

  • Ensure you have Database PgBouncer and Hostname Endpoints feature flags on
  • Checkout this PR and point to devcloud locally
  • Have a Postgres Database cluster with at least one connection pool (add via Networking tab)
pnpm test CopyTooltip
pnpm test ServiceURI

Verification steps

(How to verify changes)

  • Suspend the Postgres Database Cluster and navigate back to the suspended cluster's summary page
  • The copy icon button should be disabled with tooltip explanation
  • Resume the suspended cluster (via landing table) and navigate back to the cluster's summary page
  • The Show password, {click to reveal password}, and copy icon buttons should be disabled

@hana-akamai hana-akamai self-assigned this Mar 17, 2026
@hana-akamai hana-akamai added Bug Fixes for regressions or bugs DBaaS Relates to Database as a Service labels Mar 17, 2026
@hana-akamai hana-akamai changed the title fix: [UIE-10522] - Add resuming to disabled credential states, disable copy icon button for Service URI fix: [UIE-10522] - Disable credential buttons for resuming state Mar 17, 2026
@hana-akamai hana-akamai marked this pull request as ready for review March 17, 2026 21:22
@hana-akamai hana-akamai requested a review from a team as a code owner March 17, 2026 21:22
'resuming',
'suspended',
].includes(database.status);

Copy link
Contributor

@smans-akamai smans-akamai Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a similar change before in #13487 where failed, provisioning, and suspended statuses would throw this error for credentials. Have we confirmed that this the full list of statuses that can cause this with the backend?

We may want to check to make sure there aren't any others that can cause this such as degraded, migrating, resizing, suspending, restoring.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the backend throws an error for anything that isn't active, but it may become more permissive in the future. For example, Aiven does support reading the password for powered-off services such as suspending/suspended/resuming.

Removed failed since it's apparently no longer used by DBaaS and added suspending to the list.

The other states are very ephemeral (I wasn't able to catch the in-between resizing/restoring state), so I don't think it's a huge issue if the button isn't disabled. I think being too restrictive on the disabled state would introduce more potential issues (such as not being able to reveal if the API eventually matches Aiven's more permissive states) than the minor friction of an error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the discussion and it sounds like this could also change in the future. The different statuses you have listed for DISABLE_CREDENTIAL_STATES look good to me and we can also adjust it if we need to. This change looks good to me, thanks for looking into it!

Copy link
Contributor

@smans-akamai smans-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the verification steps and ran the unit tests. Also checked the UI and the console errors/warnings were resolved. This looks good to me!

'resuming',
'suspended',
].includes(database.status);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the discussion and it sounds like this could also change in the future. The different statuses you have listed for DISABLE_CREDENTIAL_STATES look good to me and we can also adjust it if we need to. This change looks good to me, thanks for looking into it!

@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label Mar 20, 2026
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Mar 20, 2026
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 20, 2026
@hana-akamai hana-akamai merged commit ca83906 into linode:develop Mar 23, 2026
34 of 35 checks passed
@hana-akamai hana-akamai deleted the fix-dbaas-suspended-resume-loading-states branch March 23, 2026 16:38
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs DBaaS Relates to Database as a Service

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

3 participants