upcoming: [UIE-10729] — Parity between image options in Rebuild Linode dialog with privateImageSharing flag on & off

[dwiley-akamai]

Description 📝

Ensure public images are included in the ImageSelectTable

Changes 🔄

Remove the properties in the filter that were causing public images to be excluded.

Scope 🚢

Upon production release, changes in this PR will be visible to:

• All customers
• Some customers (e.g. in Beta or Limited Availability)
• No customers / Not applicable

Target release date 🗓️

TBD

How to test 🧪

Prerequisites

Toggle the Private Image Sharing flag ON in the CM DevTool.

Reproduction steps

With the flag OFF, observe that public images such as Arch Linux are options in the Image dropdown of the Rebuild Linode dialog.

With the flag ON, observe that the table only has private images as options.

Verification steps

With the flag ON, there should be parity now with the options available on this branch locally compared to prod or DevCloud.

One way to do this is to check the images network request's results count in prod or DevCloud, and confirm the number of items in the ImageSelectTable matches that count.

To confirm the StackScript-based filtering is working when you try to rebuild from a StackScript, it would be easiest to choose or create a StackScript that is compatible with only one image. When you choose that StackScript, you should see just the expected image in the table.

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

• I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

• All tests and CI checks are passing
• TypeScript compilation succeeded without errors
• Code passes all linting rules

[dwiley-akamai]

I think this is sufficient to achieve parity because looking at its ImageSelect counterpart, the variant is "all" so there's no filtering in useAllImagesQuery():

manager/packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/Image.tsx

Lines 57 to 67 in 56cab84

	<ImageSelect
	disabled={props.disabled}
	errorText={fieldState.error?.message}
	filter={getImageSelectFilter(stackscript)}
	label="Image"
	loading={isLoading}
	noMarginTop
	onChange={(value) => field.onChange(value?.id ?? null)}
	value={field.value ?? null}
	variant="all"
	/>

and the StackScript-based filtering is applied a few lines down.

[fabrice-akamai]

Confirmed parity when PIS flag is on vs off in Rebuild Linode ✅

[bnussman-akamai]

As follow up work, could we make this new table use proper API pagination?

The API supports X-Filtering the Images endpoint on label, tags, and region so I think it would be possible. It could pay dividends in the future for accounts with tons of images.

[dwiley-akamai]

I created UIE-10836

[linode-gh-bot]

Cloud Manager UI test results

🔺 2 failing tests on test run #6 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
2 Failing	900 Passing	11 Skipped	43m 5s

Details

Failing Tests
	Spec	Test
❌	one-click-apps.spec.ts	Cloud Manager Cypress Tests→OneClick Apps (OCA) » Can view app details of a marketplace app
❌	object-storage.e2e.spec.ts	Cloud Manager Cypress Tests→object storage end-to-end tests » can update bucket access

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/oneClickApps/one-click-apps.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts"