Skip to content

upcoming: [UIE-10729] — Parity between image options in Rebuild Linode dialog with privateImageSharing flag on & off #13568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwiley-akamai merged 5 commits into from
Apr 10, 2026
Merged

upcoming: [UIE-10729] — Parity between image options in Rebuild Linode dialog with privateImageSharing flag on & off #13568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c61bace
Remove filter in useAllImagesQuery() call in ImageSelectTable.tsx; mi…
DevDW Apr 7, 2026
e798a7d
Filtering based on StackScript if in Rebuild from StackScript flow
DevDW Apr 8, 2026
04f8760
Added changeset: Private Image Sharing: include public images in imag…
DevDW Apr 8, 2026
7baf3e9
Merge branch 'develop' into UIE-10729-rebuild-with-public-images
DevDW Apr 8, 2026
07c2b06
Merge branch 'develop' into UIE-10729-rebuild-with-public-images
DevDW Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-13568-upcoming-features-1775671959206.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Upcoming Features
---

Private Image Sharing: include public images in images table in Linode Rebuild dialog ([#13568](https://github.com/linode/manager/pull/13568))
11 changes: 8 additions & 3 deletions packages/manager/src/components/ImageSelect/ImageSelectTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ interface Props {
* Error message to display above the table, e.g. from form validation.
*/
errorText?: string;
/**
* Determines whether additional filtering of images should be applied, typically if there is a StackScript selected.
*/
filter?: (image: Image) => boolean;
/**
* Callback fired when the user selects an image row.
*/
Expand All @@ -79,6 +83,7 @@ export const ImageSelectTable = (props: Props) => {
const {
currentRoute,
errorText,
filter,
onSelect,
pendoIDs,
queryParamsPrefix,
Expand Down Expand Up @@ -121,19 +126,19 @@ export const ImageSelectTable = (props: Props) => {
});

const {
data: imagesData,
data: _imagesData,
error: imagesError,
isFetching,
isLoading,
} = useAllImagesQuery(
Copy link
Copy Markdown
Member

@bnussman-akamai bnussman-akamai Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As follow up work, could we make this new table use proper API pagination?

The API supports X-Filtering the Images endpoint on label, tags, and region so I think it would be possible. It could pay dividends in the future for accounts with tons of images.

Image

Copy link
Copy Markdown
Contributor Author

@dwiley-akamai dwiley-akamai Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created UIE-10836

{},
{
...combinedFilter,
is_public: false,
type: 'manual',
Copy link
Copy Markdown
Contributor Author

@dwiley-akamai dwiley-akamai Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is sufficient to achieve parity because looking at its ImageSelect counterpart, the variant is "all" so there's no filtering in useAllImagesQuery():

manager/packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/Image.tsx

Lines 57 to 67 in 56cab84

<ImageSelect
disabled={props.disabled}
errorText={fieldState.error?.message}
filter={getImageSelectFilter(stackscript)}
label="Image"
loading={isLoading}
noMarginTop
onChange={(value) => field.onChange(value?.id ?? null)}
value={field.value ?? null}
variant="all"
/>

and the StackScript-based filtering is applied a few lines down.

}
);

const imagesData = filter ? _imagesData?.filter(filter) : _imagesData;

const pagination = usePaginationV2({
clientSidePaginationData: imagesData,
currentRoute,
Expand Down
8 changes: 6 additions & 2 deletions packages/manager/src/components/ImageSelect/ImageSelectTableRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const ImageSelectTableRow = (props: Props) => {
id,
image_sharing,
label,
regions: imageRegions,
regions: _imageRegions,
size,
status,
type,
Expand Down Expand Up @@ -77,6 +77,8 @@ export const ImageSelectTableRow = (props: Props) => {
return '—';
};

const imageRegions = _imageRegions ?? []; // Failsafe for manual images whose `regions` property is null

const FormattedRegionList = () => (
<StyledFormattedRegionList>
{imageRegions.map((region: ImageRegion, idx) => {
Expand Down Expand Up @@ -125,7 +127,9 @@ export const ImageSelectTableRow = (props: Props) => {
? pluralize('Region', 'Regions', imageRegions.length)
: '—'
}
tooltipText={<FormattedRegionList />}
tooltipText={
imageRegions?.length > 0 ? <FormattedRegionList /> : 'N/A'
}
/>
</TableCell>
</Hidden>
Expand Down
1 change: 1 addition & 0 deletions packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/Image.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export const Image = (props: Props) => {
: '/linodes') as LinkProps['to']
}
errorText={fieldState.error?.message}
filter={getImageSelectFilter(stackscript)}
onSelect={(image) => field.onChange(image?.id ?? null)}
pendoIDs={IMAGE_SELECT_TABLE_LINODE_REBUILD_PENDO_IDS}
queryParamsPrefix="images"
Expand Down
Loading