Conversation
Jskobos
left a comment
Jskobos
left a comment
There was a problem hiding this comment.
Everything makes sense. It seems like there ought to be a better way to inject environment variables into the build without writing to an .env file, but I don't know what that would be. (Maybe sjacobs would know?)
Left a few suggestions but this is all ok.
| - run: | | ||
| echo "CYPRESS_RECORD_KEY=${{ secrets.CYPRESS_RECORD_KEY }}" >> $GITHUB_ENV | ||
| echo "GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }}" >> $GITHUB_ENV | ||
| - run: | |
There was a problem hiding this comment.
I wonder if it might work here if you used the oauth variable names from above, something like container: ['OAUTH_1'...]; echo MANAGER_OAUTH=$matrix['container'] to get around the if's
There was a problem hiding this comment.
I did try that previously. I actually spent quite a while on this trying different variations. It doesn't seem to handle nested variables. I tried again just in case:
https://github.com/ndukatz/manager/actions/runs/411608785
https://github.com/ndukatz/manager/actions/runs/411620499
.github/workflows/e2e.yml
Outdated
| echo "REACT_APP_LOGIN_ROOT=https://login.linode.com" >> ./packages/manager/.env | ||
| echo "REACT_APP_API_ROOT=https://api.linode.com/v4" >> ./packages/manager/.env | ||
| echo "REACT_APP_APP_ROOT=http://localhost:3000" >> ./packages/manager/.env |
There was a problem hiding this comment.
Cloud defaults to these values, I think you don't need to put them in the .env file
There was a problem hiding this comment.
There was a problem hiding this comment.
It did not seem to work when I took them out. https://github.com/ndukatz/manager/actions/runs/431394125
|
Looks like test runs are failing because we hit our monthly test recordings limit without paying for it... I will have to talk to Adrien about this. |
This reverts commit 96e0fa2.
…e2e-actions-workflow
…e2e-actions-workflow
* Revert "Upgrade: Chart.js 3.0 (beta)" (linode#7248) This reverts commit 96e0fa2. * Changelog for Cloud Manager v1.27.1 * Add highlight.js changes to yarn.lock * Run yarn build and bump bundle size restrictions Co-authored-by: John Callahan <johnwcallahan@gmail.com> Co-authored-by: Tiffany Wong <wong.tyan@gmail.com>
Re-add Linode resize to detail view
…2e-actions-workflow
|
Here is a scheduled run that worked: https://github.com/ndukatz/manager/actions/runs/498994081. Right now I have it set to run at noon so we can test today and make sure it works. There is more refactoring and such that I will add to this later, but we want to get this initial stuff in asap. It will run against the most recent develop. |
4 participants
https://github.com/ndukatz/manager/actions/runs/409079132