refactor: [M3-6672] - Refactor <AddNewMenu /> to use MUI rather than Reach UI#9224
Merged
bnussman-akamai merged 10 commits intolinode:developfrom Jun 8, 2023
Conversation
1 failed and 2 flaky tests on run #4137 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| volume resize flow > resizes a volume |
Output
Screenshots
Video
|
|
clone-volume.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| volume clone flow > clones a volume |
Output
Screenshots
Video
|
|
update-volume.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| volume update flow > updates a volume's label and tags |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Contributor
|
Your PR has a changeset ✅ |
jaalah-akamai
approved these changes
Jun 8, 2023
Contributor
jaalah-akamai
left a comment
jaalah-akamai
left a comment
There was a problem hiding this comment.
Tested, the new menu looks good
hkhalil-akamai
approved these changes
Jun 8, 2023
Contributor
hkhalil-akamai
left a comment
hkhalil-akamai
left a comment
There was a problem hiding this comment.
Tested, looks great and the animation is slick! Code cleanup is a plus. Might want a final approval from UX since there are some minor changes to the appearance of the menu.
| marginRight: theme.spacing(1), | ||
| [theme.breakpoints.down('md')]: { | ||
| flex: 1, | ||
| const links = [ |
Contributor
There was a problem hiding this comment.
I love this, super DRY
Member
Author
|
I'll double check with UX, thanks @hkhalil-akamai! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Refactors
<AddNewMenu />to use Material UI and simplifies styles and code in generalMajor Changes 🔄
@reach/*out of the repo 🎉🗑️react-selectand@reach/*, our components will naturally become more consistant because they will pull from our MUI themePreview 📷
How to test 🧪
<AddNewMenu />