refactor: [M3-6361] - MUI v5 Migration - Components > MenuItem

[carrillo-erik]

Description 📝

MUI v5 migration for the MenuItem component.

Major Changes 🔄

• Ran tss-react codemod on MenuItem
• Replaced default export with named export, as a result the component is now imported as WrapperMenuItem

How to test 🧪

1. Verify e2e tests pass
2. Verify unit tests pass
3. Inspect for any visual regressions

[cypress]

Passing run #4621 ↗︎

0

177

3

0

0

Details:

Merge branch 'develop' of https://github.com/linode/manager into refactor/M3-636...
Project: Cloud Manager E2E	Commit: 2069119148
Status: Passed	Duration: 13:55 💡
Started: Jun 29, 2023 5:27 AM	Ended: Jun 29, 2023 5:41 AM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[dwiley-akamai]

The Create button dropdown items have a font size a bit smaller than prod currently:

Prod

This branch

In prod, editing a NodeBalancer config --> "Backend Nodes" --> the Mode dropdown has some interesting behavior. Clicking that dropdown places a white overlay on the rest of the app. That behavior isn't present on this branch, which is more aligned with other dropdowns throughout Cloud.

[carrillo-erik]

I was able to identify the same discrepancies as you stated in your comment. However, I'm unsure if my changes introduced this visual defect as the MenuItem component I touched and the one found in both of the other components (NodeBalancerConfigNode & AddNewMenu) where defect is present are different.

[bnussman-akamai]

@dwiley-akamai I refactored the "Add New" Menu to use MUI recently. This is why it might feel a bit different than normal. UX approved changes on it #9224 🎉

As for the NodeBalancer Mode dropdown. This one is unique because it uses MUI and not the React Select library. It might feel different because UX asked us to change the backdrop behavior in that same PR disucssed above https://github.com/linode/manager/pull/9224/files#diff-f767369a01cd40921dc0da8dac44cf6777e3c155f3680aa2990be0da93c2dc48R381