Skip to content

Support for deploying Network Information plugins#215

Merged
TheAssassin merged 1 commit into
linuxdeploy:masterfrom
zakalawe:deploy-network-information-plugins
May 14, 2026
Merged

Support for deploying Network Information plugins#215
TheAssassin merged 1 commit into
linuxdeploy:masterfrom
zakalawe:deploy-network-information-plugins

Conversation

@zakalawe
Copy link
Copy Markdown
Contributor

@zakalawe zakalawe commented Apr 6, 2026 •
edited by TheAssassin
Loading

Fixes: #154

dantti
dantti approved these changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@dantti dantti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheAssassin
Copy link
Copy Markdown
Member

TheAssassin commented May 14, 2026

Have not tested this explicitly, but it looks good. If CI agrees, let's merge this. Thanks @zakalawe!

@TheAssassin
Copy link
Copy Markdown
Member

TheAssassin commented May 14, 2026

Not sure why, but the actions workflow has not run. Maybe @zakalawe has disabled that in their fork?

@zakalawe
Copy link
Copy Markdown
Contributor Author

zakalawe commented May 14, 2026

Not sure why, but the actions workflow has not run. Maybe @zakalawe has disabled that in their fork?

I didn't actively enable or disable it, when creating the fork, so not sure what is going on.

@zakalawe
Copy link
Copy Markdown
Contributor Author

zakalawe commented May 14, 2026

Not sure why, but the actions workflow has not run. Maybe @zakalawe has disabled that in their fork?

I didn't actively enable or disable it, when creating the fork, so not sure what is going on.

And actions are enabled on my fork, indeed.

@TheAssassin
Copy link
Copy Markdown
Member

TheAssassin commented May 14, 2026

Looks like after a few refreshes, the approval button showed up. GitHub doing GitHub things.

@TheAssassin
Copy link
Copy Markdown
Member

TheAssassin commented May 14, 2026

Ah, I see that you pushed an update commit. That's probably why it worked this time.

@TheAssassin TheAssassin force-pushed the deploy-network-information-plugins branch from e11cdcb to e1455d0 Compare May 14, 2026 19:05
@TheAssassin TheAssassin enabled auto-merge (rebase) May 14, 2026 19:05
@TheAssassin TheAssassin merged commit e156c8a into linuxdeploy:master May 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheAssassin TheAssassin TheAssassin approved these changes

+1 more reviewer

@dantti dantti dantti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The networkinformation plugins are not deployed

3 participants

@zakalawe @TheAssassin @dantti