Skip to content

Parse numbers returned from OpenSearch #1067

Merged
themarolt merged 1 commit intomainfrom
bugfix/parse-numbers-returned-from-opensearch-C-1729
Jul 5, 2023
Merged

Parse numbers returned from OpenSearch #1067
themarolt merged 1 commit intomainfrom
bugfix/parse-numbers-returned-from-opensearch-C-1729

Conversation

@themarolt
Copy link
Copy Markdown
Contributor

@themarolt themarolt commented Jul 4, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 562a027

Refactor MemberRepository to parse numeric fields as integers. This ensures consistent data types for the Member model and improves query performance and readability.

🤖 Generated by Copilot at 562a027

Parse activeDaysCount
And activityCount as ints
Spring cleaning the code

Why

Because they were strings prefixed with 0
before:
image

after:
image

How

🤖 Generated by Copilot at 562a027

  • Parse activeDaysCount and activityCount as integers in MemberRepository to ensure consistent data types for Member model (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@themarolt themarolt added the Bug Created by Linear-GitHub Sync label Jul 4, 2023
@themarolt themarolt requested a review from epipav July 4, 2023 08:22
@themarolt themarolt merged commit 9c9acd6 into main Jul 5, 2023
@themarolt themarolt deleted the bugfix/parse-numbers-returned-from-opensearch-C-1729 branch July 5, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants