don't update an activity if it was deleted#1072
Merged
Conversation
…h - it will be created later
garrrikkotua
approved these changes
Jul 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 33f55cd
Prevent updating existing activities in
ActivityService. Add a check for thecreateflag inactivity.service.tsto avoid overwriting activities that are already created by another workers.
🤖 Generated by Copilot at 33f55cd
Why
We updated the activity we just deleted because of member mismatch.
How
🤖 Generated by Copilot at 33f55cd
createflag is false (link)Checklist ✅
Feature,Improvement, orBug.Add screehshots to the PR description for relevant FE changesNew backend functionality has been unit-tested.API documentation has been updated (if necessary) (see docs on API documentation).