Fix missing segment ids in the conversation service#1084
Merged
garrrikkotua merged 1 commit intomainfrom Jul 6, 2023
Merged
Conversation
themarolt
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 2d0c86d
Added support for segmenting conversations by source in the data sink worker and the conversations library. This involved adding a
segmentIdparameter or filter to various methods and classes that deal with conversation data, and updating the database schema to store thesegmentIdof each conversation.
🤖 Generated by Copilot at 2d0c86d
Why
How
🤖 Generated by Copilot at 2d0c86d
segmentIdparameter toConversationServicemethods to support segmenting conversations by source (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)ConversationRepositorymethods to filter queries bysegmentIdand includesegmentIdcolumn in insertions and updates (link, link, link, link, link, link, link, link, link, link, link, link, link)ConversationDataclass to includesegmentIdcolumn ininsertConversationColumnSetvalue (link)Checklist ✅
Feature,Improvement, orBug.