Skip to content

DEV.to integration#11

Merged
themarolt merged 25 commits intomainfrom
feature/devto-frontend
Aug 31, 2022
Merged

DEV.to integration#11
themarolt merged 25 commits intomainfrom
feature/devto-frontend

Conversation

@themarolt
Copy link
Copy Markdown
Contributor

@themarolt themarolt commented Aug 29, 2022

Changes proposed ✍️

  • Dev.to integration completed

    • You can now add organizations and/or users to track their articles and comments
    • You can edit an existing Dev.to integration
    • You can see Dev.to article comments as activities and conversations
    • You can see Dev.to users as community members
      • You can also see their Github and Twitter profiles if they had it set in their Dev.to profile
  • Changes affecting other parts of the system:

    • We are now sanitizing all activity body contents and displaying them as HTML since multiple sources give us HTML activities
  • Screenshots (front-end changes only)

  • New Features:

    • Dev.to integration
      image
      image
      image
      image
  • Existing feature changes:

    • Platform filters now use images instead of icons (remix icons didn't have Dev.to icon)
      image
      image
    • Activities are now shown as HTML not just as text
      image
    • Newest Member platform links were not working - now fixed
      image

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

Comment thread backend/src/serverless/integrations/iterators/devtoIterator.ts
@themarolt themarolt requested a review from mariobalca August 29, 2022 09:49
@themarolt themarolt marked this pull request as ready for review August 29, 2022 09:55
@jonathimer jonathimer changed the title Dev.to integration DEV.to integration Aug 29, 2022
Copy link
Copy Markdown
Contributor

@joanreyero joanreyero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the backend. Will leave frontend to @mariobalca. I just have a suggestion regarding a potential security vulnerability with v-html and sanitizing. Otherwise looks good to me!

Comment thread backend/src/serverless/integrations/iterators/twitterIterator.ts
Copy link
Copy Markdown
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise, most of it looks good to me!
Once you deploy to staging, I'll try help and do a small round of QA (both Visual and Functional sides)
Left some nitpicks and some questions/suggestions — let me know if you need further explanation for any of them.
And congrats on your first pull request 💪 🙌

Comment thread backend/src/api/integration/helpers/devtoValidators.ts
Comment thread backend/src/services/user/permissionChecker.ts
Comment thread frontend/src/modules/activity/components/activity-header.vue Outdated
Comment thread frontend/src/modules/activity/components/activity-platform-tabs.vue
Comment thread frontend/src/modules/conversation/components/conversation-list-table.vue Outdated
Comment thread frontend/src/modules/integration/components/integration-list.vue Outdated
@themarolt themarolt changed the base branch from main to staging/sprint-24 August 31, 2022 08:44
@themarolt themarolt changed the base branch from staging/sprint-24 to main August 31, 2022 08:44
@themarolt themarolt merged commit c3c69b1 into main Aug 31, 2022
@themarolt themarolt deleted the feature/devto-frontend branch August 31, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants