Skip to content

Hubspot automations#1172

Merged
epipav merged 49 commits intomainfrom
feature/hubspot-automations
Aug 7, 2023
Merged

Hubspot automations#1172
epipav merged 49 commits intomainfrom
feature/hubspot-automations

Conversation

@gaspergrom
Copy link
Copy Markdown
Contributor

@gaspergrom gaspergrom commented Jul 25, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 4826a24

This pull request adds a new HubSpot integration feature, which allows creating automations that send members or organizations to HubSpot based on certain conditions. It also improves the UI and code quality of the existing automation components, such as the automation form, list, and executions. It refactors the automation types configuration module and the name column of the automation list table to use a dynamic approach. It also updates some labels and URLs for the Slack and Discourse integrations.

🤖 Generated by Copilot at 4826a24

Sing, O Muse, of the skillful developers who wrought
Many wondrous automations for their loyal clients,
With the help of HubSpot, the mighty cloud-born god,
Who grants them power to sync and send their data.

Why

How

🤖 Generated by Copilot at 4826a24

  • Add HubSpot integration feature that allows sending members or organizations to HubSpot based on certain conditions (link, link, link, link, link, link, link, link)
  • Update automation types configuration to use a shared object and interface that supports new types of automations (link, link)
  • Update automation form component to render the header, action, and button slots dynamically based on the type data object (link, link, link, link, link, link)
  • Update automation list and executions components to display the name and icon of the automation type dynamically based on the automation types object (link, link, link, link, link, link)
  • Update slack integration URL from /slack/ to /config/ to avoid conflicts with other integrations (link, link)
  • Add new options for the automation trigger: member attributes match and organization attributes match (link)
  • Update label of the button that verifies the webhook configuration from "Verify webhook" to "Verify config" (link)
  • Add shared trigger component that handles the new activity and new member triggers (link)
  • Move filter options components for new activity and new member triggers to a shared folder (link, link)
  • Update logic for setting and displaying the automation name (link, link)
  • Add v-if directive to the template element to avoid rendering unnecessary elements and prevent errors (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Feature Created by Linear-GitHub Sync label Jul 25, 2023
@gaspergrom gaspergrom self-assigned this Jul 25, 2023
@gaspergrom gaspergrom requested review from epipav and removed request for epipav July 26, 2023 12:02
@gaspergrom gaspergrom requested a review from joanagmaia August 3, 2023 09:06
@epipav epipav requested a review from themarolt August 4, 2023 12:37

// set a record in membersSyncRemote to save the sourceId
// we can't use member.attributes because of segments
if (member.attributes?.sourceId?.[platform]) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

member identities can now also have sourceId if it's needed

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated processData so that sourceId is also inserted into the identity - However, I didn't change this logic because we also have this for organizations (and we don't have identities for organizations yet). I think it'll be less confusing if we get the sourceIds from syncRemote tables for both entities when pushing data

Comment thread services/apps/integration_run_worker/src/repo/automation.repo.ts Outdated
Comment thread services/scripts/build_libs.sh
@gaspergrom gaspergrom requested a review from joanagmaia August 5, 2023 15:44
@epipav epipav requested a review from themarolt August 5, 2023 22:16
@epipav epipav merged commit a5314ba into main Aug 7, 2023
@epipav epipav deleted the feature/hubspot-automations branch August 7, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants