Conversation
…crowd.dev into feature/hubspot-automations
…crowd.dev into feature/hubspot-automations
…crowd.dev into feature/hubspot-automations
themarolt
reviewed
Aug 4, 2023
|
|
||
| // set a record in membersSyncRemote to save the sourceId | ||
| // we can't use member.attributes because of segments | ||
| if (member.attributes?.sourceId?.[platform]) { |
Contributor
There was a problem hiding this comment.
member identities can now also have sourceId if it's needed
Collaborator
There was a problem hiding this comment.
I updated processData so that sourceId is also inserted into the identity - However, I didn't change this logic because we also have this for organizations (and we don't have identities for organizations yet). I think it'll be less confusing if we get the sourceIds from syncRemote tables for both entities when pushing data
joanagmaia
approved these changes
Aug 5, 2023
…utions and syncRemote rows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 4826a24
This pull request adds a new HubSpot integration feature, which allows creating automations that send members or organizations to HubSpot based on certain conditions. It also improves the UI and code quality of the existing automation components, such as the automation form, list, and executions. It refactors the automation types configuration module and the name column of the automation list table to use a dynamic approach. It also updates some labels and URLs for the Slack and Discourse integrations.
🤖 Generated by Copilot at 4826a24
Why
How
🤖 Generated by Copilot at 4826a24
/slack/to/config/to avoid conflicts with other integrations (link, link)Checklist ✅
Feature,Improvement, orBug.