Skip to content

Fix path to the docker context for python-worker#1204

Merged
themarolt merged 1 commit intolinuxfoundation:mainfrom
ayewo:feat/youtube-integration
Aug 3, 2023
Merged

Fix path to the docker context for python-worker#1204
themarolt merged 1 commit intolinuxfoundation:mainfrom
ayewo:feat/youtube-integration

Conversation

@ayewo
Copy link
Copy Markdown
Contributor

@ayewo ayewo commented Aug 1, 2023

Changes proposed ✍️

Minor change to dix the docker context for the python-worker.

What

🤖 Generated by Copilot at c95004b

Changed the contextPath for python-worker services in scripts/services/python-worker.yaml to match the new backend layout. This fixes a bug where the services could not run the python scripts.

🤖 Generated by Copilot at c95004b

The backend had a new folder design
So the services needed to realign
They changed contextPath
To avoid any wrath
From the python scripts they run online

Why

How

🤖 Generated by Copilot at c95004b

  • Update context path for python-worker and python-worker-dev services to match new backend location (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@ayewo
Copy link
Copy Markdown
Contributor Author

ayewo commented Aug 1, 2023

This is a trivial change that prevents the python-worker container from being built during the execution of"

./cli start-backend

Otherwise it will fail with the following error:

Starting service python-worker.
[+] Building 0.0s (0/0)                                                                                                                                                                                                                                                             
unable to prepare context: path "/home/ubuntu/crowd.dev/scripts/backend/src/serverless/microservices/python" not found

It is similar to the fix that was made some days ago in 2e1b627.

@ayewo
Copy link
Copy Markdown
Contributor Author

ayewo commented Aug 1, 2023

Hey @epipav 👋,
who should I be tagging for PR reviews?

@joanreyero joanreyero requested a review from themarolt August 2, 2023 19:06
@themarolt themarolt merged commit a328779 into linuxfoundation:main Aug 3, 2023
@themarolt
Copy link
Copy Markdown
Contributor

@ayewo Nice catch! Thank you for solving this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants