Skip to content

Nodejs worker fixes#1854

Merged
themarolt merged 5 commits intomainfrom
test-sqs-fix
Nov 20, 2023
Merged

Nodejs worker fixes#1854
themarolt merged 5 commits intomainfrom
test-sqs-fix

Conversation

@themarolt
Copy link
Copy Markdown
Contributor

@themarolt themarolt commented Nov 19, 2023

Changes proposed ✍️

What

🤖[deprecated] Generated by Copilot at 8ed4cc9

Refactored the SQS-related code in the backend to use the @crowd/sqs package and the @aws-sdk/client-sqs package. This improves code consistency, readability, maintainability, and performance. Removed unused code and dependencies. Enabled asynchronous search sync for nodejs workers.

🤖[deprecated] Generated by Copilot at 8ed4cc9

@crowd/sqs package
refactors and simplifies code
autumn of cleaning

Why

How

🤖[deprecated] Generated by Copilot at 8ed4cc9

  • Refactor SQS client creation and usage to use the @crowd/sqs package (link,link,link,link,link,link,link,link,link,link,link,link,link,link,link)
  • Delete unused and redundant file backend/src/utils/sqs.ts (link)
  • Update SQS types to use the @aws-sdk/client-sqs package in services/libs/sqs/src/types.ts (link)
  • Enable asynchronous search sync for nodejs workers in backend/src/services/memberService.ts by passing the syncMode argument to the searchSyncService variable (link,link,link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@themarolt themarolt changed the title Test sqs fix Nodejs worker fixes Nov 19, 2023
@themarolt themarolt merged commit 8f6ac75 into main Nov 20, 2023
@themarolt themarolt deleted the test-sqs-fix branch November 20, 2023 12:17
epipav pushed a commit that referenced this pull request Nov 21, 2023
sausage-todd pushed a commit that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants