Skip to content

Github webhooks star activities now use starred_at#259

Merged
epipav merged 5 commits intomainfrom
bugfix/github-webhooks-starred-at
Nov 28, 2022
Merged

Github webhooks star activities now use starred_at#259
epipav merged 5 commits intomainfrom
bugfix/github-webhooks-starred-at

Conversation

@epipav
Copy link
Copy Markdown
Collaborator

@epipav epipav commented Nov 28, 2022

Changes proposed ✍️

  • Github webhooks were not returning a starred_at date previously, that's why we were using the current timestamp as activity timestamp for star activities coming from webhooks. This was causing duplicate activities between the graphql activities (which returns the actual star timestamp) and webhook generated ones.
  • Now this field is returned from webhooks, and we start using this timestamp for star activities.
  • For unstar activities we're still using current timestamp as activity timestamp.
  • The tests that are using the whole api request cycle was failing bcs redis didn't exist in tests - adds a redis instance for the test setup.

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 28, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit c2f4ffb
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/6384a3cd05111800082a9bc4

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 28, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit c2f4ffb
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/6384a3cd2307580008485bf2

@epipav epipav force-pushed the bugfix/github-webhooks-starred-at branch from 6146860 to 5356055 Compare November 28, 2022 11:47
@epipav epipav marked this pull request as ready for review November 28, 2022 12:12
@epipav epipav requested a review from themarolt November 28, 2022 12:13
@epipav epipav merged commit 4daa4b1 into main Nov 28, 2022
@epipav epipav deleted the bugfix/github-webhooks-starred-at branch November 28, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants