Skip to content

Fix range filters#290

Merged
joanagmaia merged 3 commits intomainfrom
bug/range-filters
Nov 30, 2022
Merged

Fix range filters#290
joanagmaia merged 3 commits intomainfrom
bug/range-filters

Conversation

@joanagmaia
Copy link
Copy Markdown
Contributor

@joanagmaia joanagmaia commented Nov 30, 2022

Changes proposed ✍️

  • For between operators, disable apply button if both values are not valid
  • Fix filter-type-date for when between is selected

Relates to #284

Screenshots (front-end changes only)

Screenshot 2022-11-30 at 14 36 59
Screenshot 2022-11-30 at 14 37 02

Screenshot 2022-11-30 at 15 45 34
Screenshot 2022-11-30 at 15 45 39

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Nov 30, 2022
@joanagmaia joanagmaia self-assigned this Nov 30, 2022
Copy link
Copy Markdown
Contributor

@joanreyero joanreyero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@joanagmaia joanagmaia merged commit cce42e2 into main Nov 30, 2022
@joanagmaia joanagmaia deleted the bug/range-filters branch November 30, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants