Skip to content

Bugfix/twitter rate limit handling c 188#293

Merged
themarolt merged 6 commits intomainfrom
bugfix/twitter-rate-limit-handling-C-188
Dec 2, 2022
Merged

Bugfix/twitter rate limit handling c 188#293
themarolt merged 6 commits intomainfrom
bugfix/twitter-rate-limit-handling-C-188

Conversation

@themarolt
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • Twitter reach API endpoint was failing because usernames were not passed correctly as a query parameter - joined them with ,.
  • Found out that meta property is not always there in a Twitter API response so handled that.
    • because meta property was not present if no next page was available the code following the Twitter API call failed and because of that the error was not from axios and we didn't get an URL to print - refactored error handling for slack and for twitter so that we always include which URL it was.

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see [docs on API documentation](https://docs.crowd.dev/docs/updating-api-documentation)).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@themarolt themarolt added the Bug Created by Linear-GitHub Sync label Dec 1, 2022
@themarolt themarolt requested a review from joanreyero December 1, 2022 19:10
@themarolt themarolt merged commit 03ca7f4 into main Dec 2, 2022
@themarolt themarolt deleted the bugfix/twitter-rate-limit-handling-C-188 branch December 2, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants