Skip to content

Stop processing if there are no posts with such hashtag#327

Merged
themarolt merged 1 commit intomainfrom
bugfix/twitter-posts-by-hashtag-0-posts-fix-C-286
Dec 8, 2022
Merged

Stop processing if there are no posts with such hashtag#327
themarolt merged 1 commit intomainfrom
bugfix/twitter-posts-by-hashtag-0-posts-fix-C-286

Conversation

@themarolt
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • If no posts are returned there is no data except meta.result_count property that shows 0 posts returned. We have to check this and ignore processing because other properties won't be there in case there are no results.

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.~
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@themarolt themarolt added the Bug Created by Linear-GitHub Sync label Dec 8, 2022
@themarolt themarolt requested a review from joanreyero December 8, 2022 13:22
Copy link
Copy Markdown
Contributor

@joanreyero joanreyero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@themarolt themarolt merged commit 8167c66 into main Dec 8, 2022
@themarolt themarolt deleted the bugfix/twitter-posts-by-hashtag-0-posts-fix-C-286 branch December 8, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants