Skip to content

fix: deduplicate results by result id #3429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
themarolt merged 3 commits into from
Sep 25, 2025
Merged

fix: deduplicate results by result id #3429

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e3b56e
fix: deduplicate results to process before processing
themarolt Sep 24, 2025
e6ca53b
Merge branch 'main' into dsw-bugfix
themarolt Sep 25, 2025
9772602
fix: deduplicate results to process before processing
themarolt Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions services/apps/data_sink_worker/src/service/dataSink.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,13 +253,18 @@ export default class DataSinkService extends LoggerBase {
const batch: { resultId: string; data: IResultData | undefined; created: boolean }[] = []
for (const result of resultsToProcess) {
const filtered = resultsToProcess.filter((r) => r.resultId === result.resultId)
if (filtered.length > 1) {
this.log.warn(
{ resultId: result.resultId },
'Found multiple results for the same result id!',
)

// check if we already have this result in the batch
if (!batch.some((b) => b.resultId === filtered[0].resultId)) {
if (filtered.length > 1) {
this.log.warn(
{ resultId: result.resultId },
'Found multiple results for the same result id!',
)
}

batch.push(filtered[0])
}
batch.push(filtered[0])
}

this.log.trace(`[RESULTS] Processing ${batch.length} results!`)
Expand Down
Loading