Skip to content

Preserve old member email if we receive empty string from an integration#345

Merged
themarolt merged 1 commit intomainfrom
bugfix/preserve-member-email-on-empty-string-C-287
Dec 12, 2022
Merged

Preserve old member email if we receive empty string from an integration#345
themarolt merged 1 commit intomainfrom
bugfix/preserve-member-email-on-empty-string-C-287

Conversation

@themarolt
Copy link
Copy Markdown
Contributor

Changes proposed ✍️

  • If we already have an email in the database and we received an empty string from an integration we shouldn't use that empty string to upsert the member but we should keep the old email.

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@themarolt themarolt added the Bug Created by Linear-GitHub Sync label Dec 12, 2022
@themarolt themarolt requested a review from epipav December 12, 2022 12:06
@themarolt themarolt merged commit 718d28f into main Dec 12, 2022
@themarolt themarolt deleted the bugfix/preserve-member-email-on-empty-string-C-287 branch December 12, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants