Skip to content

chore(git-integration): housekeeping#3507

Merged
mbani01 merged 2 commits into
mainfrom
chore/housekeeping
Oct 14, 2025
Merged

chore(git-integration): housekeeping#3507
mbani01 merged 2 commits into
mainfrom
chore/housekeeping

Conversation

@mbani01
Copy link
Copy Markdown
Contributor

@mbani01 mbani01 commented Oct 13, 2025

This pull request makes minor adjustments to the commit_service.py and maintainer_service.py files. The most notable changes are the removal of an unused constant and the elimination of a special-case skip for "envoyproxy" repositories in maintainer processing.

Key changes:

Commit Service Improvements:

  • Removed the unused _COMMITTED_COMMIT_SUFFIX constant from the CommitService class.
  • Added a clarifying comment to explain the typo in the "commited-commit" string used for hashing, noting that correcting it would require a major migration, but that it currently has no significant effect.

Maintainer Service Logic:

  • Removed the logic that skipped maintainer processing for repositories owned by "envoyproxy," allowing these repositories to be processed like any others.

@mbani01 mbani01 requested a review from joanagmaia October 13, 2025 15:17
@mbani01 mbani01 self-assigned this Oct 13, 2025
@cursor
Copy link
Copy Markdown

cursor Bot commented Oct 13, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on November 12.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@mbani01 mbani01 merged commit c3f02db into main Oct 14, 2025
13 checks passed
@mbani01 mbani01 deleted the chore/housekeeping branch October 14, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants