Skip to content

chore(git-integration): housekeeping #3507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbani01 merged 2 commits into from
Oct 14, 2025
Merged

chore(git-integration): housekeeping #3507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2b6984
chore: remove conditional disable for specific repo
mbani01 Oct 13, 2025
f69e377
chore: add comments to typo in sourceId
mbani01 Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions services/apps/git_integration/src/crowdgit/services/commit/commit_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ class CommitService(BaseService):
_GIT_PLATFORM = "git"
_USERNAME_TYPE = "username"
_EMAIL_TYPE = "email"
_COMMITTED_COMMIT_SUFFIX = "commited-commit"

MAX_CHUNK_SIZE = 250

Expand Down Expand Up @@ -517,8 +516,10 @@ def create_activities_from_commit(

# Only create committer activity if author and committer are different
if author_name != committer_name or author_email != committer_email:
# Pre-calculate hash components to avoid repeated string operations
hash_input = f"{commit_hash}{CommitService._COMMITTED_COMMIT_SUFFIX}{committer_email}"
# IMPORTANT: hash_input has a typo in "commited" instead of "committed"
# however fixing it requires recalculating sourceId/parentSourceId for ALL git activities in db
# so far the typo doesn't have any major effect, since the activity type "committed-commit" is correct
hash_input = f"{commit_hash}commited-commit{committer_email}"
committer_source_id = hashlib.sha1(hash_input.encode("utf-8")).hexdigest()

committer = {
Expand Down
4 changes: 0 additions & 4 deletions services/apps/git_integration/src/crowdgit/services/maintainer/maintainer_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,10 +442,6 @@ async def process_maintainers(

try:
owner, repo_name = parse_repo_url(batch_info.remote)
if owner == "envoyproxy": # TODO: remove this once we figure out why it was disabled
self.logger.warning("Skiping maintainers processing for 'envoyproxy' repositories")
# Skip envoyproxy repos (based on previous logic https://github.com/CrowdDotDev/git-integration/blob/06d6395e57d9aad7f45fde2e3d7648fb7440f83b/crowdgit/maintainers.py#L86)
return

has_interval_elapsed, remaining_hours = await self.check_if_interval_elapsed(
repository
Expand Down
Loading