Skip to content

Asynchronous csv exports#356

Merged
mariobalca merged 24 commits intomainfrom
feature/async-csv-exports
Dec 22, 2022
Merged

Asynchronous csv exports#356
mariobalca merged 24 commits intomainfrom
feature/async-csv-exports

Conversation

@epipav
Copy link
Copy Markdown
Collaborator

@epipav epipav commented Dec 15, 2022

Changes proposed ✍️

  • CSV export endpoint using nodejs-worker. We now upload the generated CSV to s3 and create a temporary link to the file. The link is sent to the user via email. The CSVs live in the s3 only for a day. Also, the links expire after 15 minutes.
  • We keep the # of CSV exports per tenant in Redis. The TTL for each key is set to the end of the current month. After keys expire, with the first identifyTenant call, we set it to 0 again with new TTL.
  • Feature flags for CSV export

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@epipav epipav force-pushed the feature/async-csv-exports branch from 0f92fdf to 0f220a9 Compare December 16, 2022 13:23
@epipav epipav self-assigned this Dec 16, 2022
@epipav epipav added the Feature Created by Linear-GitHub Sync label Dec 16, 2022
@epipav epipav marked this pull request as ready for review December 16, 2022 13:44
@epipav epipav requested a review from themarolt December 16, 2022 13:44
Comment thread backend/src/bin/jobs/downgradeExpiredTrialPlans.ts Outdated
@mariobalca mariobalca merged commit 84099e3 into main Dec 22, 2022
@mariobalca mariobalca deleted the feature/async-csv-exports branch December 22, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants