feat: activityRelations and PRs lambda architecture (IN-740)#3624
Conversation
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
1 similar comment
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
2 similar comments
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
1 similar comment
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
1 similar comment
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
activityRelations and pull requests with ingestion time enrichment and lambda architectureactivityRelations and pull requests lambda architecture
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
1 similar comment
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
activityRelations and pull requests lambda architectureactivityRelations lambda architecture
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
1 similar comment
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
1 similar comment
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
1 similar comment
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
| 'pull_request-merged', | ||
| 'merge_request-merged', | ||
| 'changeset-merged' | ||
| ) |
There was a problem hiding this comment.
Bug: Unused node in pipe definition
The node new_pull_request_related_activity is defined but never referenced by any other node in the pipe. The new_events_aggregated node queries directly from activityRelations_enrich_clean_snapshot_MV_ds instead of using this node. This unused node wastes resources and suggests incomplete refactoring or debugging code left behind.
Additional Locations (1)
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
2 similar comments
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
| countDistinctState(memberId) AS contributorCount, | ||
| countDistinctState(organizationId) AS organizationCount | ||
| FROM activityRelations_deduplicated_cleaned_ds | ||
| FROM activityRelations_enrich_clean_snapshot_MV_ds |
There was a problem hiding this comment.
Bug: Missing snapshotId filter in segment aggregates MV
The segmentId_aggregates_mv reads from activityRelations_enrich_clean_snapshot_MV_ds without filtering by snapshotId. Since the MV datasource contains multiple snapshots (partitioned by toYYYYMM(snapshotId) with 1-day TTL), aggregations will include all historical snapshots rather than the latest one, producing incorrect contributor and organization counts. This should filter by the latest snapshotId like other query pipes do.
…f github.com:CrowdDotDev/crowd.dev into feat/activityRelations-and-pull-requests-lambda-arch
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
1 similar comment
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
Note
Introduce snapshot-based Lambda Architecture for Tinybird: add MVs/copy pipes/datasources with snapshotId, build PR baseline-merge pipeline, and update queries to filter latest snapshots.
LAMBDA_ARCHITECTURE.mddetailing the real-time enrichment, hourly merge, and serving layers with snapshot-based deduplication.README.mdto reference the new architecture and clarify operational notes.activityRelations_deduplicated_cleaned_ds: addsnapshotId(partition key), TTL (6h), adjust partitioning tosnapshotId.activityRelations_enrich_clean_snapshot_MV_dswith TTL (1d).pull_requests_analyzed: addsnapshotId.activityRelations_enrich_clean_snapshot_MVenriching/validating rows and assigning hourlysnapshotId.pull_request_analysis_MV_baseline_mergeandpull_request_analysis_baseline_merge_MVproducing merged PR snapshots.segmentsAggregatedMVMV input to use MV output (activityRelations_enrich_clean_snapshot_MV_ds).activityRelations_snapshot_merger_copy(hourly :10, append) to merge realtime and previous snapshots.pull_request_analysis_snapshot_merger_copy(hourly :00, replace) to refresh PR snapshots.activityRelations_enrich_clean_initial_snapshot,pull_request_analysis_initial_snapshot,segmentId_aggregates_initial_snapshot(@on-demand).contributions_with_local_timeto33 * * * *).WHERE snapshotId = (SELECT max(snapshotId) FROM ...).Written by Cursor Bugbot for commit 66232c6. This will update automatically on new commits. Configure here.