fix: use redis cache for github token connections (CM-922)#3811
Merged
fix: use redis cache for github token connections (CM-922)#3811
Conversation
Signed-off-by: Uroš Marolt <uros@marolt.me>
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
2 similar comments
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
Signed-off-by: Uroš Marolt <uros@marolt.me>
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
mbani01
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use redis cache for github token connections so we don't fetch them every time.
Note
Low Risk
Low risk: changes are limited to scheduling and an optimization via Redis caching; main risk is stale cache causing temporary failures to find token connections until invalidated/expired.
Overview
Reduces Nango GitHub connection creation overhead by caching the list of
github-token-*connection IDs in Redis (30-day TTL) and reusing it instead of fetching all Nango connections each time; addsinvalidateGithubTokenConnectionIdsCacheand exports it fromactivities.Adjusts the
nango-connection-cleanupcron schedule to run weekly (non-dev) instead of daily.Written by Cursor Bugbot for commit d486ab3. This will update automatically on new commits. Configure here.