Skip to content

fix: use redis cache for github token connections (CM-922)#3811

Merged
themarolt merged 2 commits intomainfrom
cache-github-token-connections-CM-922
Feb 3, 2026
Merged

fix: use redis cache for github token connections (CM-922)#3811
themarolt merged 2 commits intomainfrom
cache-github-token-connections-CM-922

Conversation

@themarolt
Copy link
Copy Markdown
Contributor

@themarolt themarolt commented Feb 2, 2026

Use redis cache for github token connections so we don't fetch them every time.


Note

Low Risk
Low risk: changes are limited to scheduling and an optimization via Redis caching; main risk is stale cache causing temporary failures to find token connections until invalidated/expired.

Overview
Reduces Nango GitHub connection creation overhead by caching the list of github-token-* connection IDs in Redis (30-day TTL) and reusing it instead of fetching all Nango connections each time; adds invalidateGithubTokenConnectionIdsCache and exports it from activities.

Adjusts the nango-connection-cleanup cron schedule to run weekly (non-dev) instead of daily.

Written by Cursor Bugbot for commit d486ab3. This will update automatically on new commits. Configure here.

Signed-off-by: Uroš Marolt <uros@marolt.me>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

Signed-off-by: Uroš Marolt <uros@marolt.me>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@themarolt themarolt changed the title fix: use redis cache for github token connections fix: use redis cache for github token connections (CM-922) Feb 2, 2026
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Comment thread services/apps/nango_worker/src/activities/nangoActivities.ts
@themarolt themarolt requested a review from mbani01 February 2, 2026 13:19
@themarolt themarolt merged commit 0addc55 into main Feb 3, 2026
17 checks passed
@themarolt themarolt deleted the cache-github-token-connections-CM-922 branch February 3, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants