Conversation
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
2 similar comments
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
themarolt
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor fix to the cron job interval logic in the
nango-github-syncjob definition. The change ensures that the fallback interval calculation correctly applies the development environment check.CROWD_GH_NANGO_SYNC_INTERVAL_MINUTESenvironment variable to properly use the development environment default of 5 minutes, or 60 minutes otherwise.Note
Low Risk
Small, localized change to cron scheduling logic; impact is limited to how often the job runs when the interval env var is unset.
Overview
Fixes the
nango-github-synccron interval calculation by adding parentheses so theCROWD_GH_NANGO_SYNC_INTERVAL_MINUTESenv-var fallback correctly evaluates to 5 minutes in dev and 60 minutes otherwise.This prevents operator-precedence bugs where the dev default could be incorrectly bypassed when the env var is unset.
Written by Cursor Bugbot for commit 57827df. This will update automatically on new commits. Configure here.