Skip to content

fix: nango-github-sync frequency#3818

Merged
mbani01 merged 1 commit intomainfrom
fix/github_sync_interval
Feb 3, 2026
Merged

fix: nango-github-sync frequency#3818
mbani01 merged 1 commit intomainfrom
fix/github_sync_interval

Conversation

@mbani01
Copy link
Copy Markdown
Contributor

@mbani01 mbani01 commented Feb 3, 2026

This pull request makes a minor fix to the cron job interval logic in the nango-github-sync job definition. The change ensures that the fallback interval calculation correctly applies the development environment check.

  • Fixed the fallback logic for the CROWD_GH_NANGO_SYNC_INTERVAL_MINUTES environment variable to properly use the development environment default of 5 minutes, or 60 minutes otherwise.
  • Defined CROWD_GH_NANGO_SYNC_INTERVAL_MINUTES as an env var since it was missing

Note

Low Risk
Small, localized change to cron scheduling logic; impact is limited to how often the job runs when the interval env var is unset.

Overview
Fixes the nango-github-sync cron interval calculation by adding parentheses so the CROWD_GH_NANGO_SYNC_INTERVAL_MINUTES env-var fallback correctly evaluates to 5 minutes in dev and 60 minutes otherwise.

This prevents operator-precedence bugs where the dev default could be incorrectly bypassed when the env var is unset.

Written by Cursor Bugbot for commit 57827df. This will update automatically on new commits. Configure here.

@mbani01 mbani01 requested a review from themarolt February 3, 2026 11:12
@mbani01 mbani01 self-assigned this Feb 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 3, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 3, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 3, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@mbani01 mbani01 merged commit 45162cf into main Feb 3, 2026
18 checks passed
@mbani01 mbani01 deleted the fix/github_sync_interval branch February 3, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants