fix: batch fetch repositories for integrations#3889
Merged
Conversation
Signed-off-by: Uroš Marolt <uros@marolt.me>
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
1 similar comment
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
mbani01
approved these changes
Mar 3, 2026
Signed-off-by: Uroš Marolt <uros@marolt.me>
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes how integration settings are hydrated (batch DB queries and shared
QueryExecutor), which could affect returned settings for GitHub/GitHub-Nango integrations if grouping/mapping logic has edge cases. Functional scope is limited and primarily performance-oriented.Overview
Batches integration hydration to avoid N+1 queries.
IntegrationRepository._populateRelationsForRowsnow pre-fetches Nango mappings and GitHub repos for all relevant integrations in one pass, then injectssettings.nangoMappingandsettings.orgs[].reposfrom those results.Updates DAL APIs and call sites to support multi-ID lookups. Replaces single-integration helpers with
getNangoMappingsForIntegrationsandgetReposGroupedByOrgForIntegrations, and threads a sharedQueryExecutorthrough integration population and Nango cron/worker scripts to use the new batched interfaces.Written by Cursor Bugbot for commit 61689aa. This will update automatically on new commits. Configure here.