chore: fix performance of a couple of queries (CM-1008)#3890
Merged
Conversation
Signed-off-by: Uroš Marolt <uros@marolt.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Rewrites the SQL used to count and list member/organization merge suggestions; while intended as a performance optimization, it can change result counts/order if assumptions about uniqueness or segment membership differ.
Overview
Improves performance of merge-suggestion queries for members and organizations by replacing segment-table joins with
EXISTSchecks and avoiding unnecessary joins unless adisplayNamefilter is applied.For members, the count query switches to
COUNT(*)and the list query dropsDISTINCT, relying on thememberToMergerow set plusEXISTS-based segment filtering.For organizations, the count query removes the previous
cteand counts distinct symmetric pairs via a hash, and the list query replaces segment joins withEXISTSplus scalar subselects to fetch a matching primary/secondary segment id.Written by Cursor Bugbot for commit 468c588. This will update automatically on new commits. Configure here.