Skip to content

fix: use mixed mode for flyway#3989

Merged
themarolt merged 1 commit intomainfrom
fix/flyway-mixed-mode
Apr 1, 2026
Merged

fix: use mixed mode for flyway#3989
themarolt merged 1 commit intomainfrom
fix/flyway-mixed-mode

Conversation

@themarolt
Copy link
Copy Markdown
Contributor

@themarolt themarolt commented Apr 1, 2026

Note

Medium Risk
Changes database migration execution behavior by allowing mixed transactional/non-transactional statements, which can affect migration safety/ordering and rollback characteristics at deploy time.

Overview
Enables Flyway -mixed=true in both backend/src/database/flyway_migrate.sh and backend/src/product/flyway_migrate.sh, allowing migrations that combine transactional and non-transactional statements to run successfully.

Written by Cursor Bugbot for commit cd7d111. This will update automatically on new commits. Configure here.

Signed-off-by: Uroš Marolt <uros@marolt.me>
Copilot AI review requested due to automatic review settings April 1, 2026 08:14
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@themarolt themarolt merged commit 11e8337 into main Apr 1, 2026
20 checks passed
@themarolt themarolt deleted the fix/flyway-mixed-mode branch April 1, 2026 08:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables Flyway “mixed mode” in migration scripts so migrations containing both transactional and non-transactional statements can run without failing.

Changes:

  • Add -mixed=true to Flyway CLI invocation for the “product” migration image.
  • Add -mixed=true to Flyway CLI invocation for the “database” migration image.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
backend/src/product/flyway_migrate.sh Enables Flyway mixed mode during product DB migrations.
backend/src/database/flyway_migrate.sh Enables Flyway mixed mode during database DB migrations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants