Skip to content

chore: remove superface dead code & deps#4028

Merged
mbani01 merged 1 commit into
mainfrom
chore/remove_superface_dead_code_and_deps
Apr 16, 2026
Merged

chore: remove superface dead code & deps#4028
mbani01 merged 1 commit into
mainfrom
chore/remove_superface_dead_code_and_deps

Conversation

@mbani01
Copy link
Copy Markdown
Contributor

@mbani01 mbani01 commented Apr 16, 2026

Summary

Superface was previously used for Slack chat integration (via @superfaceai/one-sdk) and Twitter OAuth (via @superfaceai/passport-twitter-oauth2). Both integrations have since been replaced or removed, leaving all Superface code completely unreferenced.

This PR removes all dead Superface code, grid profiles, and drops the two unused dependencies.

Changes

Deleted source files:

  • backend/src/serverless/integrations/usecases/chat/getMessages.ts
  • backend/src/serverless/integrations/usecases/chat/getMembers.ts
  • backend/src/serverless/integrations/usecases/chat/getMessagesThreads.ts
  • backend/src/serverless/integrations/usecases/cleanError.ts
  • backend/src/serverless/integrations/types/superfaceTypes.ts
  • backend/src/services/auth/passportStrategies/twitterStrategy.ts (was already fully commented out)

Deleted Superface grid/config files (24 files):

  • backend/superface/super.json
  • backend/superface/providers/slack.json
  • backend/superface/grid/chat/** (channels, members, messages, messages-threads, send-message, servers, threads profiles and maps)
  • backend/superface/grid/oauth2/refresh-token@1.0.0.supr
  • backend/superface/grid/social-media/** (followers, posts-lookup, profiles, publish-post, publishing-profiles)

Modified:

  • backend/package.json — removed @superfaceai/one-sdk and @superfaceai/passport-twitter-oauth2
  • .gitignore — removed /backend/superface/** entry
  • pnpm-lock.yaml — updated after dependency removal

Why it's safe

None of the deleted source files were imported anywhere in the codebase. No routes, services, or controllers depended on Superface output.

Signed-off-by: Mouad BANI <mouad-mb@outlook.com>
@mbani01 mbani01 requested a review from themarolt April 16, 2026 12:12
@mbani01 mbani01 self-assigned this Apr 16, 2026
Copilot AI review requested due to automatic review settings April 16, 2026 12:12
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes legacy Superface integration artifacts (Slack chat + Twitter OAuth) that are no longer referenced, and drops the unused Superface dependencies from the backend workspace to reduce maintenance and transitive risk.

Changes:

  • Removed @superfaceai/one-sdk and @superfaceai/passport-twitter-oauth2 from backend/package.json and updated pnpm-lock.yaml accordingly.
  • Deleted the Superface grid/config files under backend/superface/** and related serverless integration usecases/types.
  • Removed the repo-level .gitignore rule for /backend/superface/** since the directory is no longer present/used.

Reviewed changes

Copilot reviewed 31 out of 33 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pnpm-lock.yaml Removes Superface packages and their transitive dependencies from the lockfile.
backend/package.json Drops unused Superface dependencies from backend workspace dependencies.
.gitignore Removes ignore rule for backend/superface/** now that Superface is removed.
backend/superface/super.json Deletes Superface profile/provider configuration.
backend/superface/providers/slack.json Deletes Superface Slack provider definition.
backend/superface/grid/social-media/publishing-profiles@1.0.0.supr Deletes Superface social-media publishing-profiles profile.
backend/superface/grid/social-media/publish-post@1.0.0.supr Deletes Superface social-media publish-post profile.
backend/superface/grid/social-media/profiles@1.1.0.supr Deletes Superface social-media profiles profile.
backend/superface/grid/social-media/posts-lookup@1.3.0.supr Deletes Superface social-media posts-lookup profile (v1.3.0).
backend/superface/grid/social-media/posts-lookup@1.1.0.supr Deletes Superface social-media posts-lookup profile (v1.1.0).
backend/superface/grid/social-media/posts-lookup@1.0.0.supr Deletes Superface social-media posts-lookup profile (v1.0.0).
backend/superface/grid/social-media/followers@1.2.0.supr Deletes Superface social-media followers profile.
backend/superface/grid/oauth2/refresh-token@1.0.0.supr Deletes Superface oauth2 refresh-token profile.
backend/superface/grid/chat/threads/profile.supr Deletes Superface chat threads profile.
backend/superface/grid/chat/servers/profile.supr Deletes Superface chat servers profile.
backend/superface/grid/chat/send-message@1.0.0.supr Deletes Superface chat send-message profile (versioned file).
backend/superface/grid/chat/send-message/profile.supr Deletes Superface chat send-message profile (profile.supr).
backend/superface/grid/chat/send-message/maps/slack.suma Deletes Superface Slack map for send-message usecase.
backend/superface/grid/chat/messages@1.0.0.supr Deletes Superface chat messages profile.
backend/superface/grid/chat/messages/slack.suma Deletes Superface Slack map for messages usecase.
backend/superface/grid/chat/messages-threads/profile.supr Deletes Superface chat messages-threads profile.
backend/superface/grid/chat/messages-threads/maps/slack.suma Deletes Superface Slack map for messages-threads usecase.
backend/superface/grid/chat/members/profile.supr Deletes Superface chat members profile.
backend/superface/grid/chat/members/maps/slack.suma Deletes Superface Slack map for members usecase.
backend/superface/grid/chat/channels@1.0.0.supr Deletes Superface chat channels profile (versioned file).
backend/superface/grid/chat/channels/profile.supr Deletes Superface chat channels profile (profile.supr).
backend/superface/grid/chat/channels/maps/slack.suma Deletes Superface Slack map for channels usecase.
backend/src/services/auth/passportStrategies/twitterStrategy.ts Deletes commented-out Superface-based Twitter passport strategy stub.
backend/src/serverless/integrations/usecases/cleanError.ts Deletes Superface-specific error cleanup helper.
backend/src/serverless/integrations/usecases/chat/getMessagesThreads.ts Deletes Superface-based chat thread message retrieval usecase.
backend/src/serverless/integrations/usecases/chat/getMessages.ts Deletes Superface-based chat message retrieval usecase.
backend/src/serverless/integrations/usecases/chat/getMembers.ts Deletes Superface-based member listing usecase.
backend/src/serverless/integrations/types/superfaceTypes.ts Deletes Superface-specific response type used by removed usecases.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mbani01 mbani01 merged commit 8945307 into main Apr 16, 2026
24 checks passed
@mbani01 mbani01 deleted the chore/remove_superface_dead_code_and_deps branch April 16, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants